implement if_seq_no and if_primary_term parameters in bulk indexer item #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelite7
approved these changes
Jan 10, 2024
Anaethelion
approved these changes
Jan 11, 2024
|
Thank you for this great addition! |
Anaethelion
pushed a commit
that referenced
this pull request
Jan 11, 2024
Anaethelion
added a commit
that referenced
this pull request
Jan 11, 2024
…xer (#783) (#784) Co-authored-by: ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk indexer is missing the capability to set the
if_seq_noandif_primary_termparameters. I added them here with a simple addition to the unit test for the writeMeta function.I ran into concurrency problems recently with Elasticsearch. I've built a work around in my own application that was experiencing a problem, but I would like to benefit from this feature in Elasticsearch to improve my own application.
Hope this is helpful. Let me know if you need anything else from me!
ref: