Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status code label to docs metric #223

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

kruskall
Copy link
Member

❓ Why is this being changed

status is a bit confusing when debugging failed requests. Tracking the status code could improve debugging and analysis of failed requests.

πŸ§‘β€πŸ’» What is being changed

If a request fails record the status code with the elasticsearch.events.processed metric.

βœ… How to validate the change

TestAppenderFlushRequestError has been updated to validate otel metrics

If a request fails record the status code with the elasticsearch.events.processed
metric.
Improve debugging and analysis of failed requests
@kruskall kruskall requested a review from a team as a code owner December 30, 2024 19:50
@elastic-observability-automation elastic-observability-automation bot added the safe-to-test Automated label for running bench-diff on forked PRs label Dec 30, 2024
@kruskall kruskall enabled auto-merge (squash) December 30, 2024 21:15
@kruskall kruskall merged commit 530381e into elastic:main Dec 30, 2024
4 checks passed
@kruskall kruskall deleted the feat/record-status-code branch December 30, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Automated label for running bench-diff on forked PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants