Skip to content
This repository was archived by the owner on Nov 17, 2017. It is now read-only.

Update the generator to add translation capability#45

Merged
spalger merged 1 commit intoelastic:masterfrom
hickeyma:i18n_phase2
Feb 14, 2017
Merged

Update the generator to add translation capability#45
spalger merged 1 commit intoelastic:masterfrom
hickeyma:i18n_phase2

Conversation

@hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Feb 10, 2017

Add translation structure to plugins so that:

  • Plugin creators can enable translation from the off by adding internationalized strings to default 'en' translation file
  • Localization engineers can generate a translation plugin to add languages. The plugin will have all the plumbing code to register the translations with Kibana and all that needs to be added is the language translation JSON files.

This is part of Kibana globalization and elastic/kibana#8766

@hickeyma
Update the generator to add translation capability
3554876 
This commit is part og Kibana globalization and PR
elastic/kibana#8766
@hickeyma hickeyma mentioned this pull request Feb 10, 2017
Merged
@spalger spalger self-requested a review February 13, 2017 22:03
spalger
spalger approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 2136bcb into elastic:master Feb 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spalger spalger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hickeyma @spalger