[7.x](backport #457) Remove indirect build dependency on go-license-detector. #459
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
@urso @scunningham Looks like the backport has some issue. Can someone take a look to get this in? |
| @@ -34,7 +34,9 @@ done | |||
|
|
|||
| go mod tidy | |||
| go mod download | |||
| go list -m -json all $@ | go run go.elastic.co/go-licence-detector \ | |||
| GOPATH=`go env GOPATH` | |||
| env GOBIN=$GOPATH/bin/ go install go.elastic.co/[email protected] | |||
There was a problem hiding this comment.
latest or 0.4.0 (the Makefile uses latest)? In Beats we try to pin the version. Additionally we have a tools.go (that is not build) to enforce the pinning and gives us an entry in the sum file (go modules behavior changes every minor release).
An older discussion about go modules and build tools: golang/go#25922 (comment)
Unfortunately go get/install tend to mess with the local go.sum and sometimes go.mod file. A project trying to workaround that is: https://github.com/bwplotka/bingo
There was a problem hiding this comment.
Would prefer to pin it. Can switch both to 0.5.0. Or can switch it to use tools.go. Not loving this design because it generates licenses statements on a bunch of build tools that are not part of the build, and futher confuses go.mod. Ideally the tools that we use to detect/generate licenses would be built outside the target tree.
This PR fails because the 7.x branch is not picking up the new go compiler. This pr: #436 was pushed to master and backported, however the PR did not actually update the go version . To fix that , this PR: #346 was pushed to master... and for some reason not back ported.
Once we get the jenkins file fixed up, this PR should work. We can then decided if go install is the wrong way to go.
|
@Mergifyio rebase |
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7)
|
Command
|
cachedout
force-pushed
the
mergify/bp/7.x/pr-457
branch
from
ff6eae8
to
2d98e9b
Compare
This is an automatic backport of pull request #457 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/