Skip to content

Feat/9243 dogfood eslint plugin eui #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weronikaolejniczak merged 8 commits into from
Mar 24, 2026
Merged

Feat/9243 dogfood eslint plugin eui #9368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0a3340
[ESLint] Add @elastic/eui plugin to ESLint config
ragini-pandey Feb 9, 2026
cf0289b
Fix no-css-color rule crash when return argument is undefined
ragini-pandey Feb 9, 2026
baf15fa
Add changelog entry for dogfooding the `@elastic/eslint-plugin-eui` i…
ragini-pandey Feb 9, 2026
6de2189
Merge branch 'main' into feat/9243-dogfood-eslint-plugin-eui
ragini-pandey Feb 9, 2026
0adf6fc
Add changelog entry for dogfooding the `@elastic/eslint-plugin-eui`
ragini-pandey Feb 9, 2026
809ad05
Fix dogfooding enforcement for `@elastic/eslint-plugin-eui` in the `p…
ragini-pandey Feb 10, 2026
ea21ca7
Fix no-css-color rule crash when analyzing functions returning undefi…
ragini-pandey Feb 10, 2026
86769e7
Merge branch 'main' into feat/9243-dogfood-eslint-plugin-eui
weronikaolejniczak Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eslint-plugin/changelogs/upcoming/9368.md
View file
Open in desktop
Comment thread
weronikaolejniczak marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values
16 changes: 13 additions & 3 deletions packages/eslint-plugin/src/rules/no_css_color.ts
View file
Open in desktop
Comment thread
weronikaolejniczak marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,20 @@ export const NoCssColor = ESLintUtils.RuleCreator.withoutDocs({
return;
}

const returnArgument = (
functionReturnStatementNode as TSESTree.ReturnStatement
).argument;

if (
!returnArgument ||
returnArgument.type !== 'ObjectExpression'
) {
return;
}

declarationPropertiesNode = (
(functionReturnStatementNode as TSESTree.ReturnStatement)
.argument as TSESTree.ObjectExpression
)?.properties.filter(
returnArgument as TSESTree.ObjectExpression
).properties.filter(
(property): property is TSESTree.Property =>
property.type === 'Property'
);
Expand Down
4 changes: 3 additions & 1 deletion packages/eui/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ module.exports = {
'plugin:@typescript-eslint/recommended',
'plugin:deprecation/recommended',
'plugin:storybook/recommended',
'plugin:@elastic/eui/recommended',
// Prettier options need to come last, in order to override other style rules
'plugin:prettier/recommended',
],
Expand All @@ -48,7 +49,8 @@ module.exports = {
'react',
'react-hooks',
'@emotion',
'deprecation'
'deprecation',
'@elastic/eui'
],
rules: {
'deprecation/deprecation': 'warn',
Expand Down
1 change: 1 addition & 0 deletions packages/eui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"@cypress/webpack-dev-server": "^1.7.0",
"@elastic/charts": "^64.1.0",
"@elastic/datemath": "^5.0.3",
"@elastic/eslint-plugin-eui": "workspace:*",
"@elastic/eui-theme-borealis": "workspace:*",
"@emotion/babel-preset-css-prop": "^11.11.0",
"@emotion/cache": "^11.11.0",
Expand Down
3 changes: 2 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7062,7 +7062,7 @@ __metadata:
languageName: node
linkType: hard

"@elastic/eslint-plugin-eui@workspace:packages/eslint-plugin":
"@elastic/eslint-plugin-eui@workspace:*, @elastic/eslint-plugin-eui@workspace:packages/eslint-plugin":
version: 0.0.0-use.local
resolution: "@elastic/eslint-plugin-eui@workspace:packages/eslint-plugin"
dependencies:
Expand Down Expand Up @@ -7345,6 +7345,7 @@ __metadata:
"@cypress/webpack-dev-server": "npm:^1.7.0"
"@elastic/charts": "npm:^64.1.0"
"@elastic/datemath": "npm:^5.0.3"
"@elastic/eslint-plugin-eui": "workspace:*"
"@elastic/eui-theme-borealis": "workspace:*"
"@elastic/eui-theme-common": "workspace:*"
"@elastic/prismjs-esql": "npm:^1.1.2"
Expand Down