[Chore] Fix changelog GH workflow #9297
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
force-pushed
the
chore/fix-changelog-workflow
branch
6 times, most recently
from
d0e4a3b to
1d5aabe
Compare
weronikaolejniczak
force-pushed
the
chore/fix-changelog-workflow
branch
from
1d5aabe to
90e7775
Compare
Collaborator
💚 Build Succeeded |
Collaborator
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
setup-node@v6step that reuses.nvmrcandcorepack enablein the bash script.Why are we making this change?
I noticed that the change from
ubuntu-latesttoubuntu-slim(while forgetting to setup Node and enabling corepack) caused the script to fail withyarn command not found. (example 1, example 2)ubuntu-latest✨ just works ✨ but ubuntu-slim enables us to save on CI resources (especially for a quick and simple action like this one).Screenshots #
Impact to users
🟢 No impact to users. CI change.
QA
Specific checklist
Note
The script has been previously tested thoroughly on #9249