[ESLint] Warn about static z-index #9236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
force-pushed
the
feat/eslint-z-index-warning
branch
from
6782d45 to
66ef4bd
Compare
weronikaolejniczak
force-pushed
the
feat/eslint-z-index-warning
branch
4 times, most recently
from
44ecf1e to
fe9080c
Compare
weronikaolejniczak
force-pushed
the
feat/eslint-z-index-warning
branch
from
fe9080c to
7b8869b
Compare
acstll
requested changes
Dec 9, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Tested in Kibana, ran tests locally and it's working nicely, as expected. Added a comment about 2 uses cases I found that hopefully we can also cover. Let me know what you think. Thanks for tackling this one!
Contributor
Author
|
@acstll thank you for the review! I addressed your feedback, added new test cases and verified they pass: 
|
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR was co-authored with Gemini 3 Pro.
Why are we making this change?
Resolves #9230
It was raised as a suggestion on an internal meeting. If people do not reuse
euiThemetokens it's hard to assure the correct hierarchy.Screenshots #
Impact to users
🟢 No impact. Just a dev warning.
QA