-
Notifications
You must be signed in to change notification settings - Fork 861
[Local dev] Replace Babel with SWC #9229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/eui/scripts/compile-eui.js
Outdated
| } | ||
|
|
||
| args.push('src'); | ||
| if (env.SWC_MODULE_TYPE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a regular argument, why env...
packages/eui/.swcrc.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove, this doesn't work with SWC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup babel dependencies
a912128 to
29aaafe
Compare
💔 Build Failed
Failed CI StepsHistory
|
💔 Build Failed
Failed CI StepsHistory
|
|
I'm closing this PR because SWC is not a viable replacement for Babel in our case. Reason being, the Emotion SWC plugin (even though advertised as such) is not a drop-in replacement for Babel one. For example, you cannot get quite the same classnames as with Babel (even with I'm closing this PR in favor of focusing on watch mode in Kibana and potentially optimizing our Babel config and types. |
Summary
Why are we making this change?
Screenshots #
Impact to users
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles