-
Notifications
You must be signed in to change notification settings - Fork 860
[EuiSuperDatePicker] Improvements (batch 1) #9210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b13608 to
e0802ae
Compare
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Everything LGTM. I checked the additional renaming changes and had a last quick run of the new features. All works as expected. Awesome work! 🎉
💚 Build SucceededHistory
cc @acstll |
💚 Build Succeeded
History
cc @acstll |
|
CI in Kibana is green (except for Scout, which is expected): https://buildkite.com/elastic/kibana-pull-request/builds/361366#annotation-test_failures |
…ns and time zone display (#243020) ## Summary This enables 2 new features in the time picker `EuiSuperDatePicker` in Unified Search. - Time window buttons: on the top-level of the component that allow shifting the time window backwards or forward, and zooming out. - Time zone information displayed in the date/time picker popover. <img width="1362" height="968" alt="image (4)" src="https://github.com/user-attachments/assets/846f307e-12eb-41b5-9eb7-35b3540a202f" /> ## Changes - Show time window buttons aa6e065 - Show time zone information aa6e065 For more info, see elastic/eui#9210 --------- Co-authored-by: Elastic Machine <[email protected]>
…ns and time zone display (elastic#243020) ## Summary This enables 2 new features in the time picker `EuiSuperDatePicker` in Unified Search. - Time window buttons: on the top-level of the component that allow shifting the time window backwards or forward, and zooming out. - Time zone information displayed in the date/time picker popover. <img width="1362" height="968" alt="image (4)" src="https://github.com/user-attachments/assets/846f307e-12eb-41b5-9eb7-35b3540a202f" /> ## Changes - Show time window buttons aa6e065 - Show time zone information aa6e065 For more info, see elastic/eui#9210 --------- Co-authored-by: Elastic Machine <[email protected]>
…ns and time zone display (elastic#243020) ## Summary This enables 2 new features in the time picker `EuiSuperDatePicker` in Unified Search. - Time window buttons: on the top-level of the component that allow shifting the time window backwards or forward, and zooming out. - Time zone information displayed in the date/time picker popover. <img width="1362" height="968" alt="image (4)" src="https://github.com/user-attachments/assets/846f307e-12eb-41b5-9eb7-35b3540a202f" /> ## Changes - Show time window buttons aa6e065 - Show time zone information aa6e065 For more info, see elastic/eui#9210 --------- Co-authored-by: Elastic Machine <[email protected]>
Summary
Note
This PR features changes made in 2 other separate PRs already reviewed, with an extra small change in e0802ae
Implements two updates to
EuiSuperDatePicker, namely time window buttons, and time zone display, each with its own PR, previously reviewed and approved:Changes
Time window buttons (opt-in)
Buttons on the top-level of the component that allow shifting the time window backwards or forward, and zooming out.
Enable by passing
showTimeWindowButtons={true}.🔗 Storybook
showTimeWindowButtonsbooleanor EuiTimeWindowButtonsConfigfalseTime zone display (opt-in)
Time zone information displayed in the date/time picker popover.
Enable by passing
timeZoneDisplayProps={{ timeZone: TIME_ZONE_NAME }}.🔗 Storybook
timeZoneDisplayProps{}Why are we making this change?
As a series of improvements to
EuiSuperDatePickerthat should have a positive impact on end users.Impact to users
🟢 No impact, all changes are opt-in.
QA
General checklist
Checked in mobile@defaultif default values are missing) and playground togglesIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)