Skip to content

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Oct 30, 2025

Summary

closes #8783

This PR adds two new color tokens:

  • borderBaseProminent
  • borderInteractiveFormsHoverProminent

And it removes the now obsolete borderBaseFormsControl token as it's being replaced by borderBaseProminent.

Related changes

  • updates EuiFilePicker styles to use the newly added tokens and align with designs
  • updated form control styles to use borderBaseProminent which affects the border style for EuiRadio/EuiCheckbox

Additional Changes

  • ensures EuiFlyoutMenu story VRT scope includes the entire screen
  • adds updated VRT images for leftover updates

Why are we making this change?

🎨 UI consistency: Aligning with design. Adding the new tokens provides means to provide a better visual balance of borders.

Screenshots #

EuiFilePicker

LIGHT

state BEFORE AFTER
default Screenshot 2025-10-30 at 19 02 10 Screenshot 2025-10-30 at 19 00 02
hover Screenshot 2025-10-30 at 19 02 32 Screenshot 2025-10-30 at 19 02 43
disabled Screenshot 2025-10-30 at 19 03 00 Screenshot 2025-10-30 at 19 07 34

DARK

state BEFORE AFTER
default Screenshot 2025-10-30 at 19 02 15 Screenshot 2025-10-30 at 19 00 08
hover Screenshot 2025-10-30 at 19 02 23 Screenshot 2025-10-30 at 19 02 38
disabled Screenshot 2025-10-30 at 19 07 53 Screenshot 2025-10-30 at 19 07 39

EuiRadio/EuiCheckbox

BEFORE AFTER
Screenshot 2025-10-31 at 10 52 39 Screenshot 2025-10-31 at 10 52 43
Screenshot 2025-10-31 at 10 52 50 Screenshot 2025-10-31 at 10 52 53
Screenshot 2025-10-31 at 10 52 18 Screenshot 2025-10-31 at 10 52 21
Screenshot 2025-10-31 at 10 52 27 Screenshot 2025-10-31 at 10 52 29

Impact to users

🔴 This PR removes the token borderBaseFormsControl. It needs to be replaced with borderBaseProminent on consumer side.

ℹ️ The specific code updates in Kibana have been prepared here. (those might still require test/snapshot updates)

QA

  • verify that the new token values match design specs
  • verify that the updated EuiFilePicker styles match design specs (storyboook, docs)
  • verify that the updated EuiRadio (storybook) and EuiCheckbox (storybook) have updated border styles (using broderBaseProminent values)

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@mgadewoll mgadewoll self-assigned this Oct 30, 2025
@mgadewoll mgadewoll requested a review from JoseLuisGJ October 30, 2025 18:20
@mgadewoll mgadewoll marked this pull request as ready for review October 31, 2025 08:35
@mgadewoll mgadewoll requested a review from a team as a code owner October 31, 2025 08:35
@mgadewoll mgadewoll marked this pull request as draft October 31, 2025 09:38
@mgadewoll mgadewoll force-pushed the theme/8783-border-base-prominent branch from 8f8a8ab to 45de6ee Compare October 31, 2025 10:06
@mgadewoll mgadewoll added the breaking change PRs with breaking changes. (Don't delete - used for automation) label Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

Copy link
Contributor

@JoseLuisGJ JoseLuisGJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as commented here I'm working on populating the same changes in the new EUI Figma Borealis library to be in sync

@weronikaolejniczak weronikaolejniczak self-requested a review November 3, 2025 12:06
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks great 👍🏻 Thanks for updating, @mgadewoll!

Testing

Light Dark
borderBaseProminent shade50 (#A2B1C9) shade80 (#6A7FA0)
borderInteractiveFormsHoverProminent shade70 (#798EAF) shade60 (#8E9FBC)

✅ I checked token values
✅ I tested EuiFilePicker, EuiRadio and EuiCheckbox
✅ I verified that the border colors table is complete 👍🏻

@mgadewoll mgadewoll force-pushed the theme/8783-border-base-prominent branch from 9bfd7c7 to a6db557 Compare November 5, 2025 08:31
@mgadewoll mgadewoll enabled auto-merge (squash) November 5, 2025 08:44
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@mgadewoll mgadewoll merged commit 46d432a into elastic:main Nov 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation) visual refresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change token borderBaseFormsControl to a more generic one and use it for Files uploader and Dashboards

4 participants