-
Notifications
You must be signed in to change notification settings - Fork 860
[Visual Refresh] Add borderBaseProminent and borderInteractiveFormsHoverProminent tokens
#9162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual Refresh] Add borderBaseProminent and borderInteractiveFormsHoverProminent tokens
#9162
Conversation
8f8a8ab to
45de6ee
Compare
|
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
|
45de6ee to
9bfd7c7
Compare
JoseLuisGJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as commented here I'm working on populating the same changes in the new EUI Figma Borealis library to be in sync
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great 👍🏻 Thanks for updating, @mgadewoll!
Testing
| Light | Dark | |
|---|---|---|
borderBaseProminent |
shade50 (#A2B1C9) |
shade80 (#6A7FA0) |
borderInteractiveFormsHoverProminent |
shade70 (#798EAF) |
shade60 (#8E9FBC) |
✅ I checked token values
✅ I tested EuiFilePicker, EuiRadio and EuiCheckbox
✅ I verified that the border colors table is complete 👍🏻
- uses new border tokens and aligns with design
- leftover images that weren't updated previously
9bfd7c7 to
a6db557
Compare
💚 Build SucceededHistory
cc @mgadewoll |
💚 Build Succeeded
History
cc @mgadewoll |
Summary
closes #8783
This PR adds two new color tokens:
borderBaseProminentborderInteractiveFormsHoverProminentAnd it removes the now obsolete
borderBaseFormsControltoken as it's being replaced byborderBaseProminent.Related changes
EuiFilePickerstyles to use the newly added tokens and align with designsborderBaseProminentwhich affects the border style forEuiRadio/EuiCheckboxAdditional Changes
EuiFlyoutMenustory VRT scope includes the entire screenWhy are we making this change?
🎨 UI consistency: Aligning with design. Adding the new tokens provides means to provide a better visual balance of borders.
Screenshots #
EuiFilePicker
LIGHT
DARK
EuiRadio/EuiCheckbox
Impact to users
🔴 This PR removes the token
borderBaseFormsControl. It needs to be replaced withborderBaseProminenton consumer side.ℹ️ The specific code updates in Kibana have been prepared here. (those might still require test/snapshot updates)
QA
EuiFilePickerstyles match design specs (storyboook, docs)EuiRadio(storybook) andEuiCheckbox(storybook) have updated border styles (usingbroderBaseProminentvalues)General checklist
@defaultif default values are missing) and playground toggles