chore(workflows): fix changelog, don't let it hang

[acstll]

Summary

Follow-up to #9041

After the update in #9041, the individual package checks run correctly e.g. "changelog (eui)" (example), but the actual changelog check never finishes.

Why are we making this change?

To fix the changelog check in CI.

The solution

The problem seems to be that the required workflow, as per project settings in GitHub, is changelog, the name of the job which in #9041 was refactored to use a matrix strategy. I believe this was causing the check to never finish.

In order to fix this, I renamed the matrix-strategy job to changelog-checks and named changelog a new job that runs at the end of the workflow. To add this new job that will run always after changelog-checks to ensure the workflow finishes was suggested by Gemini; it might not be actually needed, but I thought it was useful to confirm the aforementioned hypothesis.

Tip

Commit history might be insightful if you have ideas for improving the workflow.

QA

• Check finishes with no changes (check)
• Check finishes after it fails (check) → working after 3dbc715
• Check finishes after it passes (check)

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 4649944
• Documentation website
• Storybook

History

• 💚 Build #1741 succeeded 7dcecac
• 💚 Build #1728 succeeded 76f5b75
• 💚 Build #1727 succeeded 70fd789
• 💚 Build #1725 succeeded 6100dbe

cc @acstll

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 4649944

History

• 💚 Build #5065 succeeded 7dcecac
• 💚 Build #5056 succeeded 76f5b75
• 💚 Build #5053 succeeded 6100dbe

cc @acstll

[mgadewoll]

General thought, non-blocking: As follow-up at some point we could check how to remove this and only have the single checks instead as this job doesn't actually do anything.

[mgadewoll]

🟢 LGTM. We can probably improve this over time but for now it fixes the issue. Thanks for tackling it! 🙏