-
Notifications
You must be signed in to change notification settings - Fork 860
[Icons] Redesign paperClip
#9149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
julianrosado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you thrown the SVG into svgomg? Other than shaving a few bits and bites this looks ammmaaziiinnng
|
Thank you @julianrosado!
not initially, I did now and added the optimized code to the description above. For the code implementation, the SVG is based on the glyph from Figma so it's already as optimized as it can be. @MichaelMarcialis @JoseLuisGJ do you have any feedback? |
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two small comments. Otherwise, assuming you're able to address them, this is good to go from my perspective. Thanks!
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Changes LGTM
💚 Build SucceededHistory
cc @acstll |
💚 Build Succeeded
History
cc @acstll |
Summary
Opening this draft to ask for feedback on the icon design.Here's a codesandbox with the icon in different sizes together with other icons for context.Redesign of the
paperClipicon following the latest guidelines.Copy/paste for Figma
Vector
Glyph
Screenshot