chore: update PR template #9126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acstll
added
the
skip-changelog
weronikaolejniczak
approved these changes
Oct 17, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
If this check is supposed to help us then I don't have anything against 😄 Maybe we could link to wiki for "smoke testing" guidelines, or at least "how to test in Kibana"?
Contributor
Author
I think that's a great idea, link to "how to test in Kibana" as an example 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the PR template to address a common pitfall: forgetting to manually test any fixes that have a direct effect in other repos.
Important
Take this as a suggestion, I'm happy to close
Why are we making this change?
To avoid shipping fixes or changes that will look good in isolation, and will include proper automated tests, etc. but still might fail to fully fulfill any external requirements.
A recent example:
search.onChangefor plain text (searchFormat="text") #9059 was shipped and released as a fix for [EuiInMemoryTable]search.onChangecallback not firing whensearchFormat="text"#9019It appeared unnecessary to do, and the PR (#9059) was properly reviewed, but some extra smoke testing would have saved some time.