[flyout system/fix] Breaking: Prevent default configuration flyouts from interacting with the Flyout System #9124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkajtoch
reviewed
Oct 17, 2025
| const { session, as, onClose, onActive, ...rest } = | ||
| usePropsWithComponentDefaults('EuiFlyout', props); | ||
| const hasActiveSession = useHasActiveSession(); | ||
| const hasActiveSession = useRef(useHasActiveSession()); |
Member
|
I love how clean the solution is! The changes work great 👏🏻 I found that opening a child flyout when a non-managed flyout is also open can look strange because of the Screen.Recording.2025-10-17.at.16.23.11.mov |
tkajtoch
approved these changes
Oct 17, 2025
where inherit is the default value
tsullivan
changed the title
tkajtoch
reviewed
Oct 17, 2025
| * - `never`: Opts out of session management and always functions as a standard flyout. | ||
| * @default 'inherit' | ||
| */ | ||
| session?: 'start' | 'inherit' | 'never'; |
Member
There was a problem hiding this comment.
nit: now that we're using string literals, could we have these defined in manager/const.ts and manager/types.ts for consistency with other values like LEVEL_MAIN?
Member
|
Everything seems to be working just fine with your latest changes @tsullivan! Code changes look good as well |
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds breaking API change to the flyout system (feature branch).
Basically, this is the same logic as before, but we're changing the type for the session flag to prevent confusion.
As a fix that comes along with this change, a flyout will no longer get "bumped" into automatically/accidentally becoming a child if it is open with the default configuration when a new main flyout gets opened. This was a bug and was causing confusion all around.