Skip to content

fix(EuiIcon, EuiBetaBadge): correct the role attribute #9100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgadewoll merged 7 commits into from
Oct 20, 2025
Merged

fix(EuiIcon, EuiBetaBadge): correct the role attribute #9100

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a521421
fix(EuiIcon, EuiBetaBadge): correct the role attribute
alexwizp Oct 14, 2025
9a1909e
changelog
alexwizp Oct 14, 2025
58a3f59
cleanup
alexwizp Oct 14, 2025
2b1d42c
fix PR comments
alexwizp Oct 20, 2025
2dff309
Update icon.test.tsx
alexwizp Oct 20, 2025
cb04899
update comment
alexwizp Oct 20, 2025
e5c93ba
Merge branch 'main' into roleattr
alexwizp Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/9100.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Accessibility**

- Fixed incorrect role attribute on `EuiIcon` and `EuiBetaBadge`
1 change: 1 addition & 0 deletions packages/eui/src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ exports[`EuiBetaBadge props tooltip and anchorProps are rendered 1`] = `
>
<span
class="euiBetaBadge emotion-euiBetaBadge-hollow-m-baseline"
role="button"
tabindex="0"
>
Beta
Expand Down
8 changes: 7 additions & 1 deletion packages/eui/src/components/badge/beta_badge/beta_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,13 @@ export const EuiBetaBadge: FunctionComponent<EuiBetaBadgeProps> = ({
title={title || label}
anchorProps={anchorProps}
>
<span tabIndex={0} css={cssStyles} className={classes} {...rest}>
<span
tabIndex={0}
role="button"
css={cssStyles}
className={classes}
{...rest}
>
{icon || label}
</span>
</EuiToolTip>
Expand Down
Loading