Skip to content

[EuiBasicTable] Do not animate loading bar when user prefers reduced motion #9095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgadewoll merged 4 commits into from
Oct 15, 2025
Merged

[EuiBasicTable] Do not animate loading bar when user prefers reduced motion #9095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
109b44f
Do not animate EuiBasicTable loading bar when user prefers reduced mo…
smith Oct 13, 2025
ceb56e6
add changelog
smith Oct 15, 2025
2704efd
Merge remote-tracking branch 'upstream/main' into nls/euitable-anim
smith Oct 15, 2025
b563ba4
Work with high contrasced and forced colors
smith Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/9095.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Accessibility**

- Make `EuiBasicTable` respect user's reduced motion setting by not animating when in loading state.
56 changes: 39 additions & 17 deletions packages/eui/src/components/basic_table/basic_table.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@

import { css, keyframes } from '@emotion/react';

import { logicalCSS, euiCantAnimate } from '../../global_styling';
import {
logicalCSS,
euiCantAnimate,
highContrastModeStyles,
preventForcedColors,
} from '../../global_styling';
import { UseEuiTheme } from '../../services';

const tableLoadingLine = keyframes`
Expand All @@ -33,23 +38,40 @@ const tableLoadingLine = keyframes`
}
`;

export const euiBasicTableBodyLoading = ({ euiTheme }: UseEuiTheme) => css`
position: relative;
overflow: hidden;

&::before {
position: absolute;
content: '';
${logicalCSS('width', '100%')}
${logicalCSS('height', euiTheme.border.width.thick)}
background-color: ${euiTheme.colors.primary};
animation: ${tableLoadingLine} 1s linear infinite;

${euiCantAnimate} {
animation-duration: 2s;
export const euiBasicTableBodyLoading = (euiThemeContext: UseEuiTheme) => {
const { euiTheme } = euiThemeContext;

return css`
position: relative;
overflow: hidden;

&::before {
position: absolute;
content: '';
${logicalCSS('width', '100%')}
${logicalCSS('height', euiTheme.border.width.thick)}
background-color: ${euiTheme.colors.primary};
animation: ${tableLoadingLine} 1s linear infinite;

${euiCantAnimate} {
animation: none;
background: repeating-linear-gradient(
-45deg,
${euiTheme.colors.backgroundBasePlain},
${euiTheme.colors.backgroundBasePlain} ${euiTheme.size.xs},
${euiTheme.colors.primary} ${euiTheme.size.xs},
${euiTheme.colors.primary} ${euiTheme.size.s}
);

${highContrastModeStyles(euiThemeContext, {
forced: `
${preventForcedColors(euiThemeContext)}
`,
})}
}
}
}
`;
`;
};

// Fix to make the loading indicator position correctly in Safari
// For whatever annoying reason, Safari doesn't respect `position: relative;`
Expand Down