-
Notifications
You must be signed in to change notification settings - Fork 861
[fix] Keep Flyout Manager sync'd across React roots. #9075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tsullivan
merged 21 commits into
feat/flyout-system
from
exploration/flyout/external-sync
Oct 15, 2025
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
766115c
[fix] Keep flyout state in sync across different React rendering roots.
clintandrewhall 0e15ec2
Merge branch 'feat/flyout-system' into exploration/flyout/external-sync
tsullivan dd5eca0
Access historyItems from the store
tsullivan 04aaa37
refactor: migrate Flyout Manager from reducer to store-based architec…
tsullivan 39ab1bd
whitespace change
tsullivan e4de6b1
Clean up storybooks
tsullivan f904630
Add ExternalRootChildFlyout to the Multi-root storybook
tsullivan 88d9d68
Render child flyout if `hasActiveSession` and `session === undefined`
tsullivan aa4db88
Merge branch 'feat/flyout-system' into exploration/flyout/external-sync
tsullivan 1cb9d38
Fix memoization issue with history items getter creating new function…
tsullivan eebf5ef
Update provider test, reset singleton store after each
tsullivan 277a3c3
Fix a memory leak in multi-root story
tsullivan a0ee5b6
Tidy up main/child routing logic
tsullivan f9f9f0f
fix build
tsullivan 37dc653
Merge branch 'feat/flyout-system' into exploration/flyout/external-sync
tsullivan 78e225a
[Flyout System] Fix session=false use cases
tsullivan a4af03a
Small improvements
tsullivan 8901717
[Flyout Top Menu] Fix close button in menu for non-managed flyouts
tsullivan 1c4b78d
Merge branch 'flyout-system/fix-session-false' into exploration/flyou…
tsullivan f68e9c2
Update packages/eui/src/components/flyout/flyout.tsx
tsullivan ebc3870
Merge branch 'feat/flyout-system' into exploration/flyout/external-sync
tsullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to other reviewers:
useSyncExternalStoreis shipped with React starting from version 18.0. We need this shim for React 17 support