Skip to content

[EuiComboBox] Break long strings properly when rowHeight="auto" #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acstll merged 3 commits into from
Oct 1, 2025
Merged

[EuiComboBox] Break long strings properly when rowHeight="auto" #9063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c8ef77
[EuiComboBox] Break long strings properly when rowHeight=auto
acstll Sep 29, 2025
50296b4
[EuiComboBox] Update story
acstll Sep 29, 2025
8e6c978
Changelog
acstll Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eui/changelogs/upcoming/9063.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated `EuiComboBox` to properly break long strings without spaces when `rowHeight="auto"`
8 changes: 0 additions & 8 deletions packages/eui/src/components/combo_box/combo_box.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { EuiFlexItem } from '../flex';

import { EuiComboBoxOptionMatcher } from './types';
import { EuiComboBox, EuiComboBoxProps } from './combo_box';
import { EuiHighlight } from '../highlight';

const options = [
{ label: 'Item 1' },
Expand Down Expand Up @@ -163,13 +162,6 @@ export const RowHeightAuto: Story = {
},
{ label: 'elastic.task_manager_metrics.metrics.task_claim.value.total' },
],
renderOption: (option, searchValue) => {
return (
<EuiHighlight search={searchValue} style={{ wordBreak: 'break-word' }}>
{option.label}
</EuiHighlight>
);
},
},
render: (args) => <StatefulComboBox {...args} />,
};
Expand Down
3 changes: 3 additions & 0 deletions ...ages/eui/src/components/combo_box/combo_box_options_list/combo_box_options_list.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export const euiComboBoxOptionListStyles = (euiThemeContext: UseEuiTheme) => {
.euiComboBoxOption__content {
flex: 1;
text-align: start;
/* Allow long strings without spaces to break,
while keeping regular sentences wrapping as expected */
overflow-wrap: anywhere;
Copy link
Contributor

@mgadewoll mgadewoll Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! And it's widely enough supported 🎉

}

.euiComboBoxOption__emptyStateText {
Expand Down