-
Notifications
You must be signed in to change notification settings - Fork 860
Reduce EuiPageHeader tabs sizes for Borealis theme
#9049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b281f9e
e0ed37c
335af17
a785c9a
9b91510
448eeb3
16b18c8
afd957d
6661a33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Added `tabsSize` theme override to size `m` for `EuiPageHeader` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { _EuiThemePageHeader } from '@elastic/eui-theme-common'; | ||
|
|
||
| export const pageHeader: _EuiThemePageHeader = { | ||
| tabsSize: 'm', // Reduced from default 'l' | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Added `_EuiThemePageHeader` type and `pageHeader` component token |
ryankeairns marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| export type _EuiThemePageHeader = { | ||
| tabsSize: string; | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Changed `EuiPageHeader` tabs to `m` size for Borealis theme |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -423,5 +423,10 @@ | |
| "euiColorBorderStrongWarning": "#966B03", | ||
| "euiColorBorderStrongRisk": "#C24411", | ||
| "euiColorBorderStrongDanger": "#C61E25", | ||
| "euiColorBorderStrongText": "#5A6D8C" | ||
| "euiColorBorderStrongText": "#5A6D8C", | ||
| "page": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💭 I'm not sure that this is really that useful on the JSON export (it's not a value to use as a token). That being said, if we add these for Borealis we should add them for Amsterdam as well (example file), otherwise switching themes would break if these are used somewhere.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, I realize, we still have these files duplicated in Originally it was duplicated when introducing Borealis as there were issues loading the file from the theme package. But that is not the case anymore and Kibana was updated (file) to use the |
||
| "pageHeader": { | ||
| "tabsSize": "m" | ||
| } | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.