Skip to content

fix: exclude EuiButtonEmpty from the @elastic/eui/no-unnamed-interactive-element rule. #9046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 2 commits into from
Sep 22, 2025
Merged

fix: exclude EuiButtonEmpty from the @elastic/eui/no-unnamed-interactive-element rule. #9046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be4252
fix: exclude EuiButtonEmpty from the @elastic/eui/no-unnamed-interact…
alexwizp Sep 22, 2025
f66e33a
changelog
alexwizp Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin/changelogs/upcoming/9046.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- exclude `EuiButtonEmpty` from the `no-unnamed-interactive-element` rule.
6 changes: 0 additions & 6 deletions packages/eslint-plugin/src/rules/a11y/no_unnamed_interactive_element.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ ruleTester.run('NoUnnamedInteractiveElement', NoUnnamedInteractiveElement, {
valid: [
// Components with allowed a11y props
{ code: '<EuiBetaBadge aria-label="Beta badge" />', languageOptions },
{ code: '<EuiButtonEmpty aria-labelledby="btnLabel" />', languageOptions },
{ code: '<EuiButtonIcon aria-label="Icon" />', languageOptions },
{ code: '<EuiComboBox aria-label="Combo label" />', languageOptions },
{ code: '<EuiSelect aria-label="Select label" />', languageOptions },
Expand Down Expand Up @@ -73,11 +72,6 @@ ruleTester.run('NoUnnamedInteractiveElement', NoUnnamedInteractiveElement, {
languageOptions,
errors: [{ messageId: 'missingA11y' }],
},
{
code: '<EuiButtonEmpty />',
languageOptions,
errors: [{ messageId: 'missingA11y' }],
},
{
code: '<EuiButtonIcon />',
languageOptions,
Expand Down
3 changes: 1 addition & 2 deletions packages/eslint-plugin/src/rules/a11y/no_unnamed_interactive_element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { hasA11yPropForComponent } from '../../utils/has_a11y_prop_for_component

const interactiveComponents = [
'EuiBetaBadge',
'EuiButtonEmpty',
'EuiButtonIcon',
'EuiComboBox',
'EuiSelect',
Expand Down Expand Up @@ -122,4 +121,4 @@ export const NoUnnamedInteractiveElement = ESLintUtils.RuleCreator.withoutDocs({
},
};
},
});
});