Skip to content

[Flyout system] Improve flyout animations #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 14 commits into from
Sep 16, 2025
Merged

[Flyout system] Improve flyout animations #9025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e5edf87
feat(EuiFlyout): add `isOpen` prop and improve opening/closing animation
tkajtoch Sep 8, 2025
72e7bc7
feat: update flyout opening and closing animation keyframes
tkajtoch Sep 9, 2025
c0c3c9d
feat(EuiFlyout): call both the input `onAnimationEnd` prop and the in…
tkajtoch Sep 9, 2025
1ff7723
feat(EuiFlyout): Update opening and closing keyframes to visually slo…
tkajtoch Sep 11, 2025
2253aeb
feat(EuiFlyout): default to `isOpen = true`
tkajtoch Sep 15, 2025
1689097
test: update EuiFlyout snapshots to include `euiFlyout--open` class name
tkajtoch Sep 15, 2025
ed977f8
feat(EuiFlyout): Update `ownFocus can be false` test snapshot to acco…
tkajtoch Sep 15, 2025
1b9769a
test(EuiFlyout): Skip `maskProps` on `shouldRenderCustomStyles` until…
tkajtoch Sep 15, 2025
9772e7f
feat(EuiFlyout): Update overlay mask workaround
tkajtoch Sep 15, 2025
a1f9998
feat(EuiFlyout): Update flyout stories to use `isOpen`
tkajtoch Sep 16, 2025
b50daa6
test: Update snapshots of EuiCollapsibleNav and EuiCollapsibleNavBeta…
tkajtoch Sep 16, 2025
3b66873
feat(EuiFlyout): Add `onClose` and `onClosing` jsdoc comments
tkajtoch Sep 16, 2025
7fdd8af
fix(EuiFlyout): Fix comments syntax in Emotion styles
tkajtoch Sep 16, 2025
e590f1d
test(EuiFlyout): Skip overlay mask cypress tests
tkajtoch Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eui-theme-borealis/src/eui_theme_borealis_dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"euiContrastRatioGraphic": 3,
"euiContrastRatioDisabled": 2,
"euiAnimSlightBounce": "cubic-bezier(0.34, 1.61, 0.7, 1)",
"euiAnimSlightResistance": "cubic-bezier(0.694, 0.0482, 0.335, 1)",
"euiAnimSlightResistance": "cubic-bezier(0.32, 0.72, 0, 1)",
"euiAnimSpeedExtraFast": "90ms",
"euiAnimSpeedFast": "150ms",
"euiAnimSpeedNormal": "250ms",
Expand Down
2 changes: 1 addition & 1 deletion packages/eui-theme-borealis/src/eui_theme_borealis_light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"euiContrastRatioGraphic": 3,
"euiContrastRatioDisabled": 2,
"euiAnimSlightBounce": "cubic-bezier(0.34, 1.61, 0.7, 1)",
"euiAnimSlightResistance": "cubic-bezier(0.694, 0.0482, 0.335, 1)",
"euiAnimSlightResistance": "cubic-bezier(0.32, 0.72, 0, 1)",
"euiAnimSpeedExtraFast": "90ms",
"euiAnimSpeedFast": "150ms",
"euiAnimSpeedNormal": "250ms",
Expand Down
2 changes: 1 addition & 1 deletion packages/eui-theme-borealis/src/variables/_animation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const animation_speed: _EuiThemeAnimationSpeeds = {

export const animation_ease: _EuiThemeAnimationEasings = {
bounce: 'cubic-bezier(.34, 1.61, .7, 1)',
resistance: 'cubic-bezier(.694, .0482, .335, 1)',
resistance: 'cubic-bezier(.32, .72, 0, 1)',
};

export const animation: _EuiThemeAnimation = {
Expand Down
2 changes: 1 addition & 1 deletion packages/eui-theme-common/src/global_styling/variables/_animations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Animations

$euiAnimSlightBounce: cubic-bezier(.34, 1.61, .7, 1) !default;
$euiAnimSlightResistance: cubic-bezier(.694, .0482, .335, 1) !default;
$euiAnimSlightResistance: cubic-bezier(.32, .72, 0, 1) !default;

$euiAnimSpeedExtraFast: 90ms !default;
$euiAnimSpeedFast: 150ms !default;
Expand Down
100 changes: 51 additions & 49 deletions packages/eui/src/components/collapsible_nav/__snapshots__/collapsible_nav.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`EuiCollapsibleNav close button can be hidden 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -69,7 +69,7 @@ exports[`EuiCollapsibleNav is rendered 1`] = `
aria-describedby="generated-id"
aria-label="aria-label"
aria-modal="true"
class="euiFlyout euiCollapsibleNav testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay-euiTestCss"
class="euiFlyout euiFlyout--open euiCollapsibleNav testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay-euiTestCss"
data-autofocus="true"
data-test-subj="test subject string"
id="id"
Expand Down Expand Up @@ -110,51 +110,53 @@ exports[`EuiCollapsibleNav is rendered 1`] = `

exports[`EuiCollapsibleNav props accepts EuiFlyout props 1`] = `
<div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-lock-disabled="false"
>
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
style="inline-size: 240px;"
<div>
Copy link
Member Author

@tkajtoch tkajtoch Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and a couple other snapshots differ because of the EuiOverlayMask change I added a comment about below. We'll revert these back when EuiOverlayMask is fixed here: #8989

<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-lock-disabled="false"
>
<p
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a non-modal dialog. To close the dialog, press Escape.

</p>
<button
aria-label="Close this dialog"
class="euiButtonIcon euiFlyout__closeButton emotion-euiButtonIcon-xs-fill-text-euiFlyout__closeButton-outside-left"
data-test-subj="euiFlyoutCloseButton"
type="button"
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
style="inline-size: 240px;"
tabindex="0"
>
<span
aria-hidden="true"
class="euiButtonIcon__icon"
color="inherit"
data-euiicon-type="cross"
/>
</button>
</nav>
<p
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a non-modal dialog. To close the dialog, press Escape.

</p>
<button
aria-label="Close this dialog"
class="euiButtonIcon euiFlyout__closeButton emotion-euiButtonIcon-xs-fill-text-euiFlyout__closeButton-outside-left"
data-test-subj="euiFlyoutCloseButton"
type="button"
>
<span
aria-hidden="true"
class="euiButtonIcon__icon"
color="inherit"
data-euiicon-type="cross"
/>
</button>
</nav>
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
</div>
`;

Expand All @@ -177,7 +179,7 @@ exports[`EuiCollapsibleNav props button 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -229,7 +231,7 @@ exports[`EuiCollapsibleNav props dockedBreakpoint 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -278,7 +280,7 @@ exports[`EuiCollapsibleNav props isDocked 1`] = `
data-focus-lock-disabled="disabled"
>
<nav
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
id="id"
style="inline-size: 320px;"
/>
Expand All @@ -305,7 +307,7 @@ exports[`EuiCollapsibleNav props onClose 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down Expand Up @@ -359,7 +361,7 @@ exports[`EuiCollapsibleNav props showButtonIfDocked 1`] = `
data-focus-lock-disabled="disabled"
>
<nav
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNav-push"
id="id"
style="inline-size: 320px;"
/>
Expand All @@ -386,7 +388,7 @@ exports[`EuiCollapsibleNav props size 1`] = `
<nav
aria-describedby="generated-id"
aria-modal="true"
class="euiFlyout euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
class="euiFlyout euiFlyout--open euiCollapsibleNav emotion-euiFlyout-none-noMaxWidth-overlay-left-left-euiCollapsibleNav-overlay"
data-autofocus="true"
id="id"
role="dialog"
Expand Down
3 changes: 2 additions & 1 deletion packages/eui/src/components/collapsible_nav/collapsible_nav.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ describe('EuiCollapsibleNav', () => {
expect(cy.get('#navSpec').should('not.exist'));
});

it('closes the nav when the overlay mask is clicked', () => {
// TODO: Unskip in https://github.com/elastic/eui/issues/8989
it.skip('closes the nav when the overlay mask is clicked', () => {
cy.realMount(<Nav />);
cy.get('[data-test-subj="navSpecButton"]').realClick();
cy.get('.euiOverlayMask').realClick({ position: 'bottomRight' });
Expand Down
4 changes: 2 additions & 2 deletions .../eui/src/components/collapsible_nav_beta/__snapshots__/collapsible_nav_beta.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ exports[`EuiCollapsibleNavBeta renders 1`] = `
>
<nav
aria-label="aria-label"
class="euiFlyout euiCollapsibleNav euiCollapsibleNavBeta testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-euiTestCss"
class="euiFlyout euiFlyout--open euiCollapsibleNav euiCollapsibleNavBeta testClass1 testClass2 emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-euiTestCss"
data-test-subj="nav"
id="generated-id_euiCollapsibleNav"
style="inline-size: 248px;"
Expand Down Expand Up @@ -89,7 +89,7 @@ exports[`EuiCollapsibleNavBeta renders initialIsCollapsed 1`] = `
>
<nav
aria-label="Site menu"
class="euiFlyout euiCollapsibleNav euiCollapsibleNavBeta emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-isPushCollapsed"
class="euiFlyout euiFlyout--open euiCollapsibleNav euiCollapsibleNavBeta emotion-euiFlyout-none-noMaxWidth-push-left-noAnimation-left-euiCollapsibleNavBeta-left-isPush-isPushCollapsed"
data-test-subj="nav"
id="generated-id_euiCollapsibleNav"
style="inline-size: 48px;"
Expand Down
Loading