Extend changelog CI checks with granular package support and skip labels #9008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
- Add upcoming directories for theme packages - Update check-changelog action to accept package-path parameter - Update entrypoint script for package-specific checks - Update workflow with change detection and granular skip labels Co-authored-by: acstll <[email protected]>
Copilot
AI
changed the title
[WIP] feat(ci): Enhance changelog check for multiple packages
Extend changelog CI checks with granular package support and skip labels
Sep 12, 2025
Contributor
There was a problem hiding this comment.
What do we need this template for?
Collaborator
💚 Build Succeededcc @acstll @Copilot |
Contributor
There was a problem hiding this comment.
This removes the check for eslint-plugin too. I'd make this more generic.
Contributor
|
Closing in favor of #9041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the changelog CI workflow to support multiple packages with granular control over skipping checks, addressing the need for more flexible changelog enforcement across the EUI monorepo.
Changes Made
🎯 Extended Package Coverage
packages/eui-theme-borealisandpackages/eui-theme-commonupcoming/directories with templates for both theme packagespackages/eui🏷️ Granular Skip Labels
Introduced package-specific skip labels alongside the existing global option:
skip-changelog:eui- Skip changelog check only for EUI packageskip-changelog:theme-borealis- Skip changelog check only for Borealis theme packageskip-changelog:theme-common- Skip changelog check only for Common theme packageskip-changelog- Global skip (existing behavior preserved)⚡ Efficient Package Detection
detect-changesjob that analyzes git diff to identify modified packages🔧 Enhanced GitHub Action
Updated
.github/actions/check-changelogto be reusable across packages:package-pathinput parameterWorkflow Logic
The new workflow follows this flow:
Example Scenarios
changelog-euijob runsskip-changelog:euiskips EUI check but allows theme checks to runBackward Compatibility
All existing functionality is preserved:
skip-changeloglabel continues to work as beforepackage-pathparameterThis enhancement provides the flexibility needed for the growing EUI ecosystem while maintaining the changelog quality standards across all packages.
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.