[EuiSuperDatePicker] Remove 1ms change in quick select time window steps #8985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this used to be correct but the Visual Refresh input update added padding on the delimiter element which wasn't considered before
packages/eui/src/components/date_picker/super_date_picker/super_date_picker.stories.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/date_picker/super_date_picker/super_date_picker.stories.tsx
Outdated
Show resolved
Hide resolved
packages/eui/src/components/date_picker/super_date_picker/super_date_picker.stories.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+576
to
+580
| act(() => { | ||
| userEvent.click( | ||
| screen.getByTestSubject('superDatePickerToggleQuickMenuButton') | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
thinking out-loud, no action required:
It'd be nice to get rid of this boilerplate with automatic act wrapping in v14 😅 and leverage async API instead.
Welp, not for this PR 🤷🏻♀️
weronikaolejniczak
approved these changes
Sep 4, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
One thing I would do for sure is improve the changelog wording so that it's clearer what was changed.
Other than that, LGTM 🟢 I tested both cases, went through the code and didn't notice anything blocking. Thanks, Lene!
Contributor
Author
|
@weronikaolejniczak The feasible improvements are applied. Thanks for the review and suggestions! |
weronikaolejniczak
approved these changes
Sep 4, 2025
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Sep 11, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <[email protected]>
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([elastic#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([elastic#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([elastic#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([elastic#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([elastic#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([elastic#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([elastic#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([elastic#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([elastic#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([elastic#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([elastic#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([elastic#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <[email protected]>
niros1
pushed a commit
to elastic/kibana
that referenced
this pull request
Sep 30, 2025
- `@elastic/eui`: `v106.4.0` ⏩ `v106.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ## [`v106.5.0`](https://github.com/elastic/eui/releases/v106.5.0) - Added an optional `offset` prop to `EuiToolTip` to allow customizing the distance (in pixels) between the tooltip and its anchor. ([#8988](elastic/eui#8988)) - Updated `EuiDataGrid` hover styles when `stripes={true}` to ensure a visible background color change on hover ([#8983](elastic/eui#8983)) **Bug fixes** - Fixed a 1ms time shift on `EuiSuperDatePicker` when using the quick select time window steps ([#8985](elastic/eui#8985)) - Fixed a visual issue in `EuiSuperDatePicker` with `isQuickSelectOnly` enabled, where delimiter padding caused an unexpected empty container ([#8985](elastic/eui#8985)) **Accessibility** - Changed the close button position in `EuiModal` to allow for the modal title to be perceivable first ([#8954](elastic/eui#8954)) - Added screen reader hint text on `EuiModal` to indicate closing behavior ([#8954](elastic/eui#8954)) --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to elastic/kibana#232393 (comment)
This PR updates
EuiSuperDatePickerby removing a1mstime shift in the quick select time window steps.The original intention of this shift is not clear, the code was added ~7 years ago here.
Removing this shift ensures that the time window keeps a stable time window.
Additional changes
isQuickSelectOnlystate, where the updated delimiter element padding would result in an unexpected empty container showingWhy are we making this change?
Fixes a reported issue with unexpected 1ms time shifts when using the quick select time window steps.
Screenshots
quick select time window changes
Screen.Recording.2025-08-28.at.11.38.33.mov
Screen.Recording.2025-08-28.at.11.39.04.mov
Screen.Recording.2025-08-27.at.14.09.01.mov
Screen.Recording.2025-08-27.at.14.06.08.mov
isQuickSelectOnlychangesScreen.Recording.2025-08-28.at.11.51.16.mov
Screen.Recording.2025-08-28.at.11.51.29.mov
Impact to users
🟢 There are no updates required on consumer side.
QA
ℹ️ To verify this change doesn't cause trouble on Kibana side, this change was also run in Kibana CI (build) and deployed here (credentials)
isQuickSelectOnlystate looks as expectedGeneral checklist
Checked in both light and dark modesChecked in both MacOS and Windows high contrast modesChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)