-
Notifications
You must be signed in to change notification settings - Fork 895
[EuiButtonEmpty] Revert xs size font size change
#8930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mgadewoll
merged 5 commits into
elastic:main
from
mgadewoll:buttons/revert-xs-font-size-change
Jul 31, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
244869a
refactor: revert button xs font-size related changes from #8778
mgadewoll 2decf4d
test(vrt) update reference images
mgadewoll 677e827
test(vrt) update unrelated reference images
mgadewoll f60ad93
chore: add changelog
mgadewoll 3582dd5
chore: update changelog
mgadewoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+12.3 KB
...reference/chrome_desktop_Display_EuiCheckableCard_With_Interactive_Children.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+14.1 KB
...rence/chrome_desktop_Display_EuiCheckableCard_With_Non_Interactive_Children.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-248 Bytes
(99%)
...s/eui/.loki/reference/chrome_desktop_Display_EuiTour_EuiTourStep_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-284 Bytes
(99%)
.../reference/chrome_desktop_Forms_EuiForm_EuiFormControlLayout_Append_Prepend.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-285 Bytes
(99%)
...i/reference/chrome_desktop_Forms_EuiForm_EuiFormControlLayout_High_Contrast.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-311 Bytes
(99%)
...e/chrome_desktop_Forms_EuiForm_EuiFormControlLayout_High_Contrast_Dark_Mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-139 Bytes
(99%)
...hrome_desktop_Forms_EuiSuperDatePicker_EuiSuperDatePicker_Quick_Select_Only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.31 KB
(100%)
...nce/chrome_desktop_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_m_Child_Size_s.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.13 KB
(100%)
...nce/chrome_desktop_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_s_Child_Size_m.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.13 KB
(100%)
...nce/chrome_desktop_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_s_Child_Size_s.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+27 KB
.../.loki/reference/chrome_desktop_Layout_EuiFlyout_Flyout_System_Basic_Flyout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-509 Bytes
(98%)
...eui/.loki/reference/chrome_desktop_Tabular_Content_EuiBasicTable_Marked_Row.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-506 Bytes
(98%)
...eui/.loki/reference/chrome_desktop_Tabular_Content_EuiBasicTable_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-704 Bytes
(99%)
...eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Cell_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-654 Bytes
(99%)
...reference/chrome_desktop_Tabular_Content_EuiDataGrid_Cell_Expansion_Popover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-737 Bytes
(99%)
...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Column_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-713 Bytes
(99%)
.../reference/chrome_desktop_Tabular_Content_EuiDataGrid_Custom_Header_Content.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-734 Bytes
(99%)
...loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Draggable_Columns.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-574 Bytes
(99%)
...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-755 Bytes
(98%)
...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-746 Bytes
(99%)
...s/eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-455 Bytes
(98%)
...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Virtualization.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-734 Bytes
(99%)
...reference/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Compact.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-733 Bytes
(99%)
...eference/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Expanded.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-741 Bytes
(99%)
.../chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Horizontal_Lines.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-741 Bytes
(99%)
...reference/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Minimal.png
Oops, something went wrong.
Binary file modified
BIN
-723 Bytes
(99%)
...erence/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-727 Bytes
(99%)
...rence/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Row_Classes.png
Oops, something went wrong.
Binary file modified
BIN
-267 Bytes
(100%)
...ence/chrome_desktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto.png
Oops, something went wrong.
Binary file modified
BIN
-292 Bytes
(99%)
...op_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto_Below_Line_Count.png
Oops, something went wrong.
Binary file modified
BIN
-279 Bytes
(99%)
...sktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Line_Height.png
Oops, something went wrong.
Binary file modified
BIN
-265 Bytes
(100%)
...ontent_EuiDataGrid_rowHeightsOptions_prop_Custom_Line_Height_Control_Column.png
Oops, something went wrong.
Binary file modified
BIN
-269 Bytes
(100%)
...sktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Row_Heights.png
Oops, something went wrong.
Binary file modified
BIN
-258 Bytes
(100%)
...hrome_desktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Line_Count.png
Oops, something went wrong.
Binary file modified
BIN
-272 Bytes
(99%)
...ome_desktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Line_Count_1.png
Oops, something went wrong.
Binary file modified
BIN
-302 Bytes
(100%)
...me_desktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Static_Height.png
Oops, something went wrong.
Binary file modified
BIN
-596 Bytes
(94%)
...ular_Content_EuiDataGrid_toolbarVisibility_prop_Additional_Controls_Options.png
Oops, something went wrong.
Binary file modified
BIN
-636 Bytes
(95%)
..._desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png
Oops, something went wrong.
Binary file modified
BIN
-602 Bytes
(96%)
...e_desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png
Oops, something went wrong.
Binary file modified
BIN
-631 Bytes
(97%)
...desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png
Oops, something went wrong.
Binary file modified
BIN
-356 Bytes
(97%)
...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png
Oops, something went wrong.
Binary file modified
BIN
-264 Bytes
(100%)
...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png
Oops, something went wrong.
Binary file modified
BIN
-451 Bytes
(100%)
...hrome_desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_No_Toolbar.png
Oops, something went wrong.
Binary file modified
BIN
-948 Bytes
(99%)
...op_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Render_Custom_Toolbar.png
Oops, something went wrong.
Binary file modified
BIN
-727 Bytes
(99%)
...bular_Content_EuiDataGrid_toolbarVisibility_prop_Toolbar_Visibility_Options.png
Oops, something went wrong.
Binary file modified
BIN
-530 Bytes
(99%)
...loki/reference/chrome_desktop_Tabular_Content_EuiInMemoryTable_Kitchen_Sink.png
Oops, something went wrong.
Binary file modified
BIN
-546 Bytes
(87%)
...rence/chrome_desktop_Tabular_Content_EuiTable_EuiTablePagination_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-253 Bytes
(87%)
...Tabular_Content_EuiTable_Mobile_subcomponents_EuiTableSortMobile_Playground.png
Oops, something went wrong.
Binary file added
BIN
+25.5 KB
.../reference/chrome_mobile_Display_EuiCheckableCard_With_Interactive_Children.png
Oops, something went wrong.
Binary file added
BIN
+29.3 KB
...erence/chrome_mobile_Display_EuiCheckableCard_With_Non_Interactive_Children.png
Oops, something went wrong.
Binary file modified
BIN
-334 Bytes
(99%)
...es/eui/.loki/reference/chrome_mobile_Display_EuiTour_EuiTourStep_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-388 Bytes
(100%)
...i/reference/chrome_mobile_Forms_EuiForm_EuiFormControlLayout_Append_Prepend.png
Oops, something went wrong.
Binary file modified
BIN
-463 Bytes
(100%)
...ki/reference/chrome_mobile_Forms_EuiForm_EuiFormControlLayout_High_Contrast.png
Oops, something went wrong.
Binary file modified
BIN
-354 Bytes
(100%)
...ce/chrome_mobile_Forms_EuiForm_EuiFormControlLayout_High_Contrast_Dark_Mode.png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...es/eui/.loki/reference/chrome_mobile_Forms_EuiForm_EuiFormRow_Column_Layout.png
Oops, something went wrong.
Binary file modified
BIN
-36 Bytes
(100%)
packages/eui/.loki/reference/chrome_mobile_Forms_EuiRange_High_Contrast.png
Oops, something went wrong.
Binary file modified
BIN
-3 Bytes
(100%)
packages/eui/.loki/reference/chrome_mobile_Forms_EuiRange_Input.png
Oops, something went wrong.
Binary file modified
BIN
-401 Bytes
(99%)
...chrome_mobile_Forms_EuiSuperDatePicker_EuiSuperDatePicker_Quick_Select_Only.png
Oops, something went wrong.
Binary file modified
BIN
+821 Bytes
(100%)
...ence/chrome_mobile_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_m_Child_Size_s.png
Oops, something went wrong.
Binary file modified
BIN
+796 Bytes
(100%)
...ence/chrome_mobile_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_s_Child_Size_m.png
Oops, something went wrong.
Binary file modified
BIN
+796 Bytes
(100%)
...ence/chrome_mobile_Layout_EuiFlyout_EuiFlyoutChild_Main_Size_s_Child_Size_s.png
Oops, something went wrong.
Binary file added
BIN
+62 KB
...i/.loki/reference/chrome_mobile_Layout_EuiFlyout_Flyout_System_Basic_Flyout.png
Oops, something went wrong.
Binary file modified
BIN
-1.06 KB
(98%)
.../eui/.loki/reference/chrome_mobile_Tabular_Content_EuiBasicTable_Marked_Row.png
Oops, something went wrong.
Binary file modified
BIN
-1.05 KB
(99%)
.../eui/.loki/reference/chrome_mobile_Tabular_Content_EuiBasicTable_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-614 Bytes
(100%)
.../eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Cell_Actions.png
Oops, something went wrong.
Binary file modified
BIN
-628 Bytes
(100%)
.../reference/chrome_mobile_Tabular_Content_EuiDataGrid_Cell_Expansion_Popover.png
Oops, something went wrong.
Binary file modified
BIN
-620 Bytes
(100%)
...ui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Column_Actions.png
Oops, something went wrong.
Binary file modified
BIN
-616 Bytes
(100%)
...i/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Custom_Header_Content.png
Oops, something went wrong.
Binary file modified
BIN
-618 Bytes
(100%)
....loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Draggable_Columns.png
Oops, something went wrong.
Binary file modified
BIN
-32 Bytes
(100%)
...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png
Oops, something went wrong.
Binary file modified
BIN
-1.24 KB
(97%)
...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png
Oops, something went wrong.
Binary file modified
BIN
-619 Bytes
(100%)
...es/eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-671 Bytes
(99%)
...ui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Virtualization.png
Oops, something went wrong.
Binary file modified
BIN
-621 Bytes
(100%)
.../reference/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Compact.png
Oops, something went wrong.
Binary file modified
BIN
-631 Bytes
(99%)
...reference/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Expanded.png
Oops, something went wrong.
Binary file modified
BIN
-622 Bytes
(99%)
...e/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Horizontal_Lines.png
Oops, something went wrong.
Binary file modified
BIN
-708 Bytes
(99%)
.../reference/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Minimal.png
Oops, something went wrong.
Binary file modified
BIN
-608 Bytes
(99%)
...ference/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-604 Bytes
(99%)
...erence/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Row_Classes.png
Oops, something went wrong.
Binary file modified
BIN
-594 Bytes
(99%)
...rence/chrome_mobile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto.png
Oops, something went wrong.
Binary file modified
BIN
-603 Bytes
(99%)
...le_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto_Below_Line_Count.png
Oops, something went wrong.
Binary file modified
BIN
-669 Bytes
(99%)
...obile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Line_Height.png
Oops, something went wrong.
Binary file modified
BIN
-674 Bytes
(99%)
...ontent_EuiDataGrid_rowHeightsOptions_prop_Custom_Line_Height_Control_Column.png
Oops, something went wrong.
Binary file modified
BIN
-625 Bytes
(99%)
...obile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Custom_Row_Heights.png
Oops, something went wrong.
Binary file modified
BIN
-631 Bytes
(99%)
...chrome_mobile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Line_Count.png
Oops, something went wrong.
Binary file modified
BIN
-664 Bytes
(99%)
...rome_mobile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Line_Count_1.png
Oops, something went wrong.
Binary file modified
BIN
-662 Bytes
(99%)
...ome_mobile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Static_Height.png
Oops, something went wrong.
Binary file modified
BIN
-1.21 KB
(95%)
...e_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png
Oops, something went wrong.
Binary file modified
BIN
+1.17 KB
(100%)
...me_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png
Oops, something went wrong.
Binary file modified
BIN
-396 Bytes
(99%)
..._mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png
Oops, something went wrong.
Binary file modified
BIN
-595 Bytes
(97%)
...obile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png
Oops, something went wrong.
Binary file modified
BIN
-611 Bytes
(100%)
...chrome_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_No_Toolbar.png
Oops, something went wrong.
Binary file modified
BIN
-1.02 KB
(99%)
...le_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Render_Custom_Toolbar.png
Oops, something went wrong.
Binary file modified
BIN
-613 Bytes
(100%)
...bular_Content_EuiDataGrid_toolbarVisibility_prop_Toolbar_Visibility_Options.png
Oops, something went wrong.
Binary file modified
BIN
-1.01 KB
(99%)
....loki/reference/chrome_mobile_Tabular_Content_EuiInMemoryTable_Kitchen_Sink.png
Oops, something went wrong.
Binary file modified
BIN
-682 Bytes
(92%)
...erence/chrome_mobile_Tabular_Content_EuiTable_EuiTablePagination_Playground.png
Oops, something went wrong.
Binary file modified
BIN
-449 Bytes
(87%)
...Tabular_Content_EuiTable_Mobile_subcomponents_EuiTableSortMobile_Playground.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| **Bug fixes** | ||
|
|
||
| - Reverted a font-size change for `xs` buttons back to `12px` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.