[Visual Refresh][EuiCode] Update background color #8813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
changed the title
- adds new components.forms.codeInlineBackground token
mgadewoll
force-pushed
the
code/update-background-color
branch
from
c4e00ae to
16605fa
Compare
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
ek-so
approved these changes
Jun 26, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
I tested the changes in the staging docs, specifically Inline example
| backgroundBasePlain | backgroundBaseSubdued | backgroundBaseHighlighted | |
|---|---|---|---|
light mode (rgb(236, 241, 249) > #ECF1F9 - not #F6F9FC ❌) |
 |
 |
 |
dark mode (rgb(23, 35, 54) > #172336 ✅) |
 |
 |
 |
Dev tools
Light mode
Dark mode
The light mode seems a tiny bit different? 🤔
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
Contributor
Author
@weronikaolejniczak Thanks for noticing that! Turns out I simply can't copy the right color value 🙈
|
weronikaolejniczak
approved these changes
Jun 26, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM! 🟢 Thank you, Lene 😄
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Jul 2, 2025
`104.0.2` ⏩ `104.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v104.1.0`](https://github.com/elastic/eui/releases/v104.1.0) - Added new component token `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813)) - Updated background color for `EuiCode` to use `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813)) - Added `noItemsMessage` prop to `EuiInMemoryTable` ([#8812](elastic/eui#8812)) - Added prop `delimiter` on `EuiDatePickerRange` ([#8810](elastic/eui#8810)) **Bug fixes** - Fixed an issue with `EuiSuperDatePicker` where toggling `isQuickSelectOnly` would cause a full re-render when the selected range uses absolute dates ([#8810](elastic/eui#8810)) **Deprecations** - Deprecated `message` prop in `EuiInMemoryTable` in favor of `noItemsMessage` which is a more meaningful prop name; there are no functional changes ([#8812](elastic/eui#8812)) ### `@elastic/eui-theme-borealis` #### [`v3.1.0`](https://github.com/elastic/eui/releases/v3.1.0) - Added new component token `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813))
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
`104.0.2` ⏩ `104.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v104.1.0`](https://github.com/elastic/eui/releases/v104.1.0) - Added new component token `components.forms.codeInlineBackground` ([elastic#8813](elastic/eui#8813)) - Updated background color for `EuiCode` to use `components.forms.codeInlineBackground` ([elastic#8813](elastic/eui#8813)) - Added `noItemsMessage` prop to `EuiInMemoryTable` ([elastic#8812](elastic/eui#8812)) - Added prop `delimiter` on `EuiDatePickerRange` ([elastic#8810](elastic/eui#8810)) **Bug fixes** - Fixed an issue with `EuiSuperDatePicker` where toggling `isQuickSelectOnly` would cause a full re-render when the selected range uses absolute dates ([elastic#8810](elastic/eui#8810)) **Deprecations** - Deprecated `message` prop in `EuiInMemoryTable` in favor of `noItemsMessage` which is a more meaningful prop name; there are no functional changes ([elastic#8812](elastic/eui#8812)) ### `@elastic/eui-theme-borealis` #### [`v3.1.0`](https://github.com/elastic/eui/releases/v3.1.0) - Added new component token `components.forms.codeInlineBackground` ([elastic#8813](elastic/eui#8813))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the current background color for
EuiCodeforlightcolor mode.Changes
components.forms.codeInlineBackgroundtoken#ECF1F9/ shade135#172336(light/dark)EuiCodeto usecomponents.forms.codeInlineBackgroundinstead ofcomponents.forms.codeBackgroundWhy are we making this change?
This change ensures that the inline
EuiCodeis visible on thebackgroundBaseSubduedandbackgroundBaseHighlightedwhich are used for container backgrounds.Screenshots
Impact to users
🟢 There are no required changes on consumer side due to this update.
QA
📖 EuiCode docs
EuiCodecomponent has the expected new background color#ECF1F9in light mode and uses#172336in dark modeGeneral checklist
Checked in both MacOS and Windows high contrast modesChecked in mobileChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)