[Amsterdam] Update values for border-strong-* tokens
#8794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acstll
added
skip-changelog
20 tasks
mgadewoll
reviewed
Jun 13, 2025
packages/eui/src/themes/amsterdam/global_styling/variables/_colors.ts
Outdated
Show resolved
Hide resolved
| borderStrongAccent: computed( | ||
| ([borderBaseAccent]) => borderBaseAccent, | ||
| ['colors.borderBaseAccent'] | ||
| ([accent]) => tint(accent, 0.1), |
Contributor
There was a problem hiding this comment.
Hmm, looking at the previous usages for border colors in Amsterdam, I'd think we should use the colors without tint. Using the brand colors directly for:
primary
accent
accentSecondary
success
warning
danger
And for neutral and risk I think we could use the severity colors directly then as well.
Contributor
Author
There was a problem hiding this comment.
I trust you blindly on this one, will update 👍
acstll
force-pushed
the
border-strong-ams
branch
from
05c202c to
9dd5924
Compare
mgadewoll
reviewed
Jun 13, 2025
packages/eui/src/themes/amsterdam/global_styling/variables/_colors.ts
Outdated
Show resolved
Hide resolved
packages/eui/src/themes/amsterdam/global_styling/variables/_colors.ts
Outdated
Show resolved
Hide resolved
Collaborator
💚 Build SucceededHistory
cc @acstll |
mgadewoll
approved these changes
Jun 13, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 Changes looking good, the output makes sense. Thanks for the update!
Collaborator
💚 Build Succeeded
History
cc @acstll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #8769 there was the need to update the color token used for the selected outline in the Data Grid, to be
border-strong-primary. In order to make this work in Amsterdam, the value for the token also had to be updated.In this PR all
border-strong-*tokens get an adequate value so they could actually useful beyond the change in the aforementioned PR.Why are we making this change?
Because it's needed for #8769 and it made sense to make a separate PR.
Screenshots
The codesandbox used to generate and "test" the colors.
The
border-strongcolor is the second in each block e.g.tint(accent, 0.1).Impact to users
Minimal to none because these tokens didn't exist previously in Amsterdam, before Borealis.
QA