Skip to content

Disable generation of sourcemaps for @elastic/eui-theme-borealis and @elastic/eui-theme-common #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 3 commits into from
Jun 6, 2025
Merged

Disable generation of sourcemaps for @elastic/eui-theme-borealis and @elastic/eui-theme-common #8764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18cf3b5
build(eui-theme-borealis): disable generation of sourcemaps
tkajtoch Jun 6, 2025
e59d7f3
build(eui-theme-common): disable generation of sourcemaps
tkajtoch Jun 6, 2025
7444560
chore: add changelogs
tkajtoch Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/eui-theme-borealis/changelogs/upcoming/8764.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed missing source map warnings emitted by some bundlers by excluding source maps from being published
- To align with `@elastic/eui` and many other popular packages, we made a call to not ship source maps anymore
Copy link
Member Author

@tkajtoch tkajtoch Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually provide explanations, but this feels different. We don't necessarily have a section to publish package-specific information; It's closest to a bug fix as it fixes bundler warnings and isn't a breaking change.
I guess this whole thing is in the grey area...

2 changes: 1 addition & 1 deletion packages/eui-theme-borealis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build:clean": "rimraf lib/",
"build": "yarn build:clean && yarn build:compile && yarn build:compile:cjs && yarn build:types && yarn copy-files",
"build:compile": "tsc --project ./tsconfig.json",
"build:compile:cjs": "NODE_ENV=production NO_COREJS_POLYFILL=true babel src --out-dir=lib/cjs --extensions .js,.ts,.tsx --source-maps=true",
"build:compile:cjs": "NODE_ENV=production NO_COREJS_POLYFILL=true babel src --out-dir=lib/cjs --extensions .js,.ts,.tsx",
"build:types": "NODE_ENV=production tsc --project tsconfig.types.json",
"build-pack": "yarn build && npm pack",
"copy-files": "node ./scripts/copy-json-files.js",
Expand Down
3 changes: 1 addition & 2 deletions packages/eui-theme-borealis/tsconfig.cjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
],
"moduleResolution": "Node",
"declaration": true,
"sourceMap": true,
"noEmitHelpers": true,
"incremental": true,
"esModuleInterop": true,
Expand All @@ -26,4 +25,4 @@
"exclude": [
"node_modules"
],
}
}
3 changes: 1 addition & 2 deletions packages/eui-theme-borealis/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
],
"moduleResolution": "Node",
"declaration": true,
"sourceMap": true,
"noEmitHelpers": true,
"incremental": true,
"esModuleInterop": true,
Expand All @@ -25,4 +24,4 @@
"exclude": [
"node_modules"
],
}
}
3 changes: 1 addition & 2 deletions packages/eui-theme-borealis/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
"compilerOptions": {
"outDir": "lib/cjs",
"declaration": true,
"declarationMap": true,
"isolatedModules": false,
"noEmit": false,
"allowJs": false,
"emitDeclarationOnly": true
},
"exclude": ["node_modules", "**/*.test.ts"]
}
}
4 changes: 4 additions & 0 deletions packages/eui-theme-common/changelogs/upcoming/8764.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed missing source map warnings emitted by some bundlers by excluding source maps from being published
- To align with `@elastic/eui` and many other popular packages, we made a call to not ship source maps anymore
2 changes: 1 addition & 1 deletion packages/eui-theme-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"build:clean": "rimraf lib/",
"build": "yarn build:clean && yarn build:compile && yarn build:compile:cjs && yarn build:types",
"build:compile": "tsc --project ./tsconfig.json",
"build:compile:cjs": "NODE_ENV=production NO_COREJS_POLYFILL=true babel src --out-dir=lib/cjs --extensions .js,.ts,.tsx --source-maps=true",
"build:compile:cjs": "NODE_ENV=production NO_COREJS_POLYFILL=true babel src --out-dir=lib/cjs --extensions .js,.ts,.tsx",
"build:types": "NODE_ENV=production tsc --project tsconfig.types.json",
"build-pack": "yarn build && npm pack",
"lint": "yarn tsc --noEmit && yarn lint-es && yarn lint-sass",
Expand Down
3 changes: 1 addition & 2 deletions packages/eui-theme-common/tsconfig.cjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
],
"moduleResolution": "Node",
"declaration": true,
"sourceMap": true,
"noEmitHelpers": true,
"incremental": true,
"esModuleInterop": true,
Expand All @@ -26,4 +25,4 @@
"exclude": [
"node_modules"
],
}
}
3 changes: 1 addition & 2 deletions packages/eui-theme-common/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
],
"moduleResolution": "Node",
"declaration": true,
"sourceMap": true,
"noEmitHelpers": true,
"incremental": true,
"esModuleInterop": true,
Expand All @@ -25,4 +24,4 @@
"exclude": [
"node_modules"
],
}
}
3 changes: 1 addition & 2 deletions packages/eui-theme-common/tsconfig.types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
"compilerOptions": {
"outDir": "lib/cjs",
"declaration": true,
"declarationMap": true,
"isolatedModules": false,
"noEmit": false,
"allowJs": false,
"emitDeclarationOnly": true
},
"exclude": ["node_modules", "**/*.test.ts"]
}
}