Skip to content

Conversation

@gvnmagni
Copy link
Contributor

This is, hopefully, a small addition to our documentation. Within Patterns, I have included a new Health & Severity dedicated page with descriptions of Severity Levels with a list of available tokens and a few guidelines on how to use them.

First time making a PR for EUI so please feel free to suggest changes or fixes

@gvnmagni gvnmagni requested a review from mgadewoll April 28, 2025 13:25
@gvnmagni gvnmagni requested a review from a team as a code owner April 28, 2025 13:25
@cla-checker-service
Copy link

cla-checker-service bot commented Apr 28, 2025

💚 CLA has been signed

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Changes are looking good to me 👍 Just one small copy suggestion.


## Use cases

The following mapping does not necessarily want to be comprehensive of all use cases but it serves as an example of how the Health & Severity levels might be applied. Different contexts and environments might need dedicated terminology, therefore these levels can be used with alternative, customised variations in terms of words and naming, serving the dedicated purpose while aligning the use of colors across the product.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick: Maybe we could rephrase "The following mapping does not necessarily want to be comprehensive of all use cases" a bit:

Suggestion: "The following mapping is not exhaustive of all use cases"

@mgadewoll
Copy link
Contributor

ℹ️ I added an additional commit that adds missing token output on the Color token page which I forgot to add on the previous PR that introduced the tokens.

@gvnmagni gvnmagni force-pushed the severity-patterns-page branch from 8017778 to fe0f8f5 Compare April 29, 2025 09:23
@gvnmagni gvnmagni added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Apr 29, 2025
@JasonStoltz

This comment was marked as resolved.

@JasonStoltz

This comment was marked as resolved.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll
Copy link
Contributor

@JasonStoltz Checked your updated and it works as expected 👍

@mgadewoll mgadewoll merged commit 4b5d7c0 into main Apr 29, 2025
5 checks passed
@mgadewoll mgadewoll deleted the severity-patterns-page branch April 29, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants