-
Notifications
You must be signed in to change notification settings - Fork 861
Severity pattern page #8650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Severity pattern page #8650
Conversation
|
💚 CLA has been signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Changes are looking good to me 👍 Just one small copy suggestion.
|
|
||
| ## Use cases | ||
|
|
||
| The following mapping does not necessarily want to be comprehensive of all use cases but it serves as an example of how the Health & Severity levels might be applied. Different contexts and environments might need dedicated terminology, therefore these levels can be used with alternative, customised variations in terms of words and naming, serving the dedicated purpose while aligning the use of colors across the product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick: Maybe we could rephrase "The following mapping does not necessarily want to be comprehensive of all use cases" a bit:
Suggestion: "The following mapping is not exhaustive of all use cases"
|
ℹ️ I added an additional commit that adds missing token output on the Color token page which I forgot to add on the previous PR that introduced the tokens. |
8017778 to
fe0f8f5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
|
@JasonStoltz Checked your updated and it works as expected 👍 |
This is, hopefully, a small addition to our documentation. Within Patterns, I have included a new Health & Severity dedicated page with descriptions of Severity Levels with a list of available tokens and a few guidelines on how to use them.
First time making a PR for EUI so please feel free to suggest changes or fixes