Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Mar 20, 2025

Summary

Closes #8465

I fixed the hero button and links that were not clickable due to an overlapping decor wrapper. I also fixed several broken links across the page. Additionally, I updated external links to open in a new tab for improved user experience.

Screenshots

Screenshot 2025-03-20 at 12 08 02
Screenshot 2025-03-20 at 13 19 34
Screenshot 2025-03-20 at 13 19 48
Screenshot 2025-03-20 at 13 19 59
Screenshot 2025-03-20 at 13 20 10
Screenshot 2025-03-20 at 13 20 20
Screenshot 2025-03-20 at 13 20 24

For cases where the topic spanned multiple pages, I chose the page I thought would be most useful:

  • "Form" card > "Basic text controls" page
  • "All components" button > "Getting Started" page
  • "Tokens" card > "Colors" page

QA

  • Verify that all the links on the homepage are functional
  • including ensuring external links opening in a new tab

@weronikaolejniczak weronikaolejniczak added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Mar 20, 2025
@weronikaolejniczak weronikaolejniczak self-assigned this Mar 20, 2025
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review March 20, 2025 12:32
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner March 20, 2025 12:32
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

@weronikaolejniczak
Copy link
Contributor Author

@mgadewoll I switched to relative links which are working both locally and in staging (with the PR prefix). Could you re-test?

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all links work correctly now ✅

@weronikaolejniczak weronikaolejniczak merged commit a92efee into elastic:main Mar 20, 2025
5 checks passed
@weronikaolejniczak weronikaolejniczak deleted the fix/eui-plus-homepage-links branch April 16, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EUI+] Fix all broken links on the homepage

4 participants