[EUI+] Broken subcategory names

[weronikaolejniczak]

Summary

Closes #8407

This PR fixes the underscore names for Form subcategories. The difference comes from merging the reorganization PR and the guidelines PR.

Before	After

I left Form controls > Guidelines page as is. It's a bit awkward because it's the only page there but it doesn't belong to any other section (Text controls / Selection controls etc.). One other idea I had was to add a Guidelines page to every specific "X controls" page but it would lead to a lot of duplicated content. If you have any idea how to improve, I'm open to updating it on this PR!

QA

• Verify the new page names are correct
• Verify all links redirecting to these pages work as expected

[kibanamachine]

Preview staging links for this PR:

• Docs site: https://eui.elastic.co/pr_8408/
• Storybook: https://eui.elastic.co/pr_8408/storybook
• New docs: https://eui.elastic.co/pr_8408/new-docs

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: a5d4f4a

History

• 💔 Build #3604 failed 7df29db
• 💔 Build #3602 failed 80e0c37

[acstll]

This LGTM as is 🚢

I left Form controls > Guidelines page as is. It's a bit awkward because it's the only page there but it doesn't belong to any other section (Text controls / Selection controls etc.).

it's a bit awkward indeed but I don't think it's that bad… how about removing the form_controls folder, and placing this Guidelines page directly under Forms? 🤔

[weronikaolejniczak]

@acstll I thought about that as well but those Guidelines do not describe Forms in general but specifically the Form Controls.

[acstll]

@acstll I thought about that as well but those Guidelines do not describe Forms in general but specifically the Form Controls.

then I think it's fine as it is 🙂