[Visual Refresh] Update Borealis VRT reference images #8384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive state - increasing the range ensures we don't have to update the snapshot in another years time
- updates all reference images after Borealis is now the default theme
mgadewoll
added
skip-changelog
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
cc @mgadewoll |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
This PR is a follow-up to this PR that enabled
Borealisas default theme in EUI.Before merging the
eui-theme/borealisfeature branch intomainwe need to update ALL VRT images based on the new enabled theme.Changes
EuiSuperDatePickerstory to use a date in the future as max range value to ensure parity with expected state and prevent having to update the value soon againℹ️ There is one small visual regression for
EuiToasthighlight borders (being slightly cut off and not perfectly rounded) that is partially unexpected but I will add the changes as separate update as it requires a generic update to how the floating borders are currently used across panelled components.QA
I did make sure to run over all updated VRT images having a general look if the changes are expected. 🔍 👀
yarn test-visual-regression update- this should NOT result in any updated images