Skip to content

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Feb 11, 2025

Summary

Important

This PR merges into a feature branch.

This PR fixes the values for 2 backgroundLight JSON tokens that were incorrect.

QA

  • verify that backgroundLight tokens in LIGHT mode use the color values for primitive colors of shade 20 (see the color definitions here)

@mgadewoll mgadewoll added skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) visual refresh labels Feb 11, 2025
@mgadewoll mgadewoll self-assigned this Feb 11, 2025
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review February 11, 2025 10:11
@mgadewoll mgadewoll requested a review from a team as a code owner February 11, 2025 10:11
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Great job, Lene!

Screenshot 2025-02-11 at 11 33 39

All backgroundLight tokens use 20 shades.

@mgadewoll mgadewoll merged commit eb26a87 into elastic:eui-theme/borealis Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) visual refresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants