Skip to content

[EuiInlineEditForm] Support onCancel callback for non-controlled usage #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgadewoll merged 4 commits into from
Feb 11, 2025
Merged

[EuiInlineEditForm] Support onCancel callback for non-controlled usage #8307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c91b33f
refactor: update shared onCancel type for EuiInlineEdit components
mgadewoll Feb 4, 2025
8fa75be
chore: add changelog
mgadewoll Feb 4, 2025
929d5c6
fix: update typo
mgadewoll Feb 5, 2025
ac49122
chore: update typo
mgadewoll Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/eui/changelogs/upcoming/8307.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Updated `EuiInlineEditForm`'s `onCancel` prop type to allow uncontrolled mode usage

3 changes: 2 additions & 1 deletion packages/eui/src/components/inline_edit/inline_edit_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export type EuiInlineEditCommonProps = Omit<
* Initial inline edit text value
*/
defaultValue: string;
onCancel?: (previousValue: string) => void;
},
{
/**
Expand All @@ -109,7 +110,7 @@ export type EuiInlineEditCommonProps = Omit<
/**
* Callback required to reset `value` to the previous read mode text value.
*/
onCancel: (perviousValue: string) => void;
onCancel: (previousValue: string) => void;
}
>;

Expand Down