Skip to content

Remap few colors for EuiLoadingSpinner and EuiLoadingChart #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgadewoll merged 12 commits into from
Jan 17, 2025
Merged

Remap few colors for EuiLoadingSpinner and EuiLoadingChart #8276

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5a13932
Changed mono spinner mapping
ek-so Jan 15, 2025
64850e1
Change spinner mapping
ek-so Jan 15, 2025
cf3bc4f
Unit tests
ek-so Jan 15, 2025
f5be8ae
Changed mono spinner mapping
ek-so Jan 15, 2025
32c8db6
Change spinner mapping
ek-so Jan 15, 2025
d6ee13a
Unit tests
ek-so Jan 15, 2025
d6966eb
Merge branch 'ekso-loading-chart-remap' of https://github.com/ek-so/e…
ek-so Jan 16, 2025
30e0d0d
Component tokens mapping
ek-so Jan 16, 2025
c49aa15
One more time
ek-so Jan 16, 2025
fd10e54
Format code
ek-so Jan 16, 2025
a08d17c
Format
ek-so Jan 16, 2025
1b768e7
Format code
ek-so Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/eui-theme-borealis/src/variables/_components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,10 @@ export const components: _EuiThemeComponents = {
listGroupItemBackgroundPrimaryHover:
dark_background_colors.backgroundBaseInteractiveHover,

loadingChartMonoBackground0: SEMANTIC_COLORS.shade95,
loadingChartMonoBackground1: SEMANTIC_COLORS.shade105,
loadingChartMonoBackground2: SEMANTIC_COLORS.shade115,
loadingChartMonoBackground3: SEMANTIC_COLORS.shade125,
loadingChartMonoBackground0: SEMANTIC_COLORS.shade110,
loadingChartMonoBackground1: SEMANTIC_COLORS.shade100,
loadingChartMonoBackground2: SEMANTIC_COLORS.shade90,
loadingChartMonoBackground3: SEMANTIC_COLORS.shade80,

markBackground: dark_background_colors.backgroundLightPrimary,

Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/button/__snapshots__/button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ exports[`EuiButton props isLoading is rendered 1`] = `
aria-label="Loading"
class="euiLoadingSpinner emotion-euiLoadingSpinner-m"
role="progressbar"
style="border-color: #0077cc currentcolor currentcolor currentcolor;"
style="border-color: #99c9eb currentcolor currentcolor currentcolor;"
/>
</span>
</button>
Expand Down
2 changes: 1 addition & 1 deletion .../src/components/button/button_display/__snapshots__/_button_display_content.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`EuiButtonDisplayContent button icon loading icon renders disabled & loa
aria-label="Loading"
class="euiLoadingSpinner emotion-euiLoadingSpinner-m"
role="progressbar"
style="border-color: #0077cc currentcolor currentcolor currentcolor;"
style="border-color: #99c9eb currentcolor currentcolor currentcolor;"
/>
<span
class="eui-textTruncate"
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ exports[`EuiButtonEmpty props isLoading is rendered 1`] = `
aria-label="Loading"
class="euiLoadingSpinner emotion-euiLoadingSpinner-m"
role="progressbar"
style="border-color: #0077cc currentcolor currentcolor currentcolor;"
style="border-color: #99c9eb currentcolor currentcolor currentcolor;"
/>
<span
class="eui-textTruncate euiButtonEmpty__text"
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ exports[`EuiButtonIcon props isLoading is rendered 1`] = `
aria-label="Loading"
class="euiLoadingSpinner emotion-euiLoadingSpinner-m"
role="progressbar"
style="border-color: #0077cc currentcolor currentcolor currentcolor;"
style="border-color: #99c9eb currentcolor currentcolor currentcolor;"
/>
</button>
`;
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/loading/__snapshots__/loading_spinner.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`EuiLoadingSpinner custom colors 1`] = `
aria-label="Loading"
class="euiLoadingSpinner emotion-euiLoadingSpinner-m"
role="progressbar"
style="border-color: #0077cc white white white;"
style="border-color: #99c9eb white white white;"
/>
<span
aria-label="Loading"
Expand Down
4 changes: 2 additions & 2 deletions packages/eui/src/components/loading/loading_spinner.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export const euiSpinnerBorderColorsCSS = (
colors: EuiLoadingSpinnerColor = {}
): string => {
const {
border = euiTheme.colors.lightShade,
highlight = euiTheme.colors.primary,
border = euiTheme.colors.borderBasePlain,
highlight = euiTheme.colors.borderStrongPrimary,
Comment thread
mgadewoll marked this conversation as resolved.
Outdated
} = colors;
return `${highlight} ${border} ${border} ${border}`;
};
Expand Down