[EuiSuperDatePicker] Fix locale date string test #8258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on yearly changing week days
1 task
mgadewoll
force-pushed
the
superdatepicker/fix-date-string-locale-test
branch
from
3fb401d to
96eeec5
Compare
mgadewoll
added
the
skip-changelog
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
acstll
approved these changes
Jan 7, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Passes locally for me. LGTM 👌
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
weronikaolejniczak
pushed a commit
to cee-chen/eui
that referenced
this pull request
Feb 10, 2025
weronikaolejniczak
pushed a commit
that referenced
this pull request
Feb 14, 2025
weronikaolejniczak
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
EuiSuperdatePickerabsolute_tab.test.tsxtest by adding a year to the passed date string to prevent tests breaking on yearly changing week days.Example failing test:
The issue was that January 1st was a Monday in 2024, but is not a Monday in 2025.
We should fix the date to the year to ensure the test works generally.
QA
packages/euiand runyarn test-unit src/components/date_picker/super_date_picker/date_popover/absolute_tab.test.tsx