[Visual Refresh] Severity palette order for Amsterdam #8254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
mgadewoll
approved these changes
Jan 6, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
Thanks for the fix! 🙏
My brain was somewhere else it seems when adding those 🙈
mgadewoll
pushed a commit
that referenced
this pull request
Jan 7, 2025
6 tasks
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
This PR introduces no changes in the implementation of the new Severity palette.
It only fixes a mistake in the implementation (#8247), where the values for the severity levels from 1 (low) to 14 (high) were inverted for the Amsterdam theme. Thank you @maxcold for reporting.
QA
Probably not needed, but an extra manual double-check wouldn't hurt.