Skip to content

[EuiPagination] Add keys for i18n values in compressed count #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acstll merged 5 commits into from
Jan 7, 2025
Merged

[EuiPagination] Add keys for i18n values in compressed count #8243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
179198f
[EuiPagination] Add keys for i18n values in compressed count
acstll Dec 16, 2024
f28db27
Changelog
acstll Dec 16, 2024
313d22c
Improve changelog item to make it more generic
acstll Dec 17, 2024
d3e7e5e
Rename changelog file
acstll Dec 17, 2024
2b005e1
Merge branch 'main' into pagination-i18n-keys
acstll Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/8243.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Ensures that the `values` of `EuiI18n` used in `EuiPagination` use `key` attributes to prevent potential ["unique key" warnings](https://react.dev/learn/rendering-lists#keeping-list-items-in-order-with-key).
4 changes: 2 additions & 2 deletions packages/eui/src/components/pagination/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ export const EuiPagination: FunctionComponent<Props> = ({
token="euiPagination.pageOfTotalCompressed"
default="{page} of {total}"
values={{
page: <span>{activePage + 1}</span>,
total: <span>{pageCount}</span>,
page: <span key="activePage">{activePage + 1}</span>,
total: <span key="pageCount">{pageCount}</span>,
}}
/>
</EuiText>
Expand Down
Loading