Skip to content

[Visual Refresh] Set darker shade for subdued text #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryankeairns merged 2 commits into from
Dec 12, 2024
Merged

[Visual Refresh] Set darker shade for subdued text #8224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9530eea
Set darker shade for subdued text
ryankeairns Dec 11, 2024
fe76361
refactor: update euiTextSubduedColor to darker shade
mgadewoll Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eui-theme-borealis/src/eui_theme_borealis_light.json
View file
Open in desktop
Copy link
Contributor

@mgadewoll mgadewoll Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note: This file is currently not the one used in Kibana (there were issues loading this file somehow from this new package 🤷‍♀️) so we decided to duplicate the file for now into eui.
We need to update this file here too to keep them in sync.

Copy link
Contributor

@mgadewoll mgadewoll Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryankeairns I went ahead to add the small update, I hope you don't mind! (commit)

Copy link
Contributor Author

@ryankeairns ryankeairns Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you!

Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@
"euiColorHighlight": "#E5F3FF",
"euiTextColor": "#172336",
"euiTitleColor": "#111C2C",
"euiTextSubduedColor": "#5A6D8C",
"euiTextSubduedColor": "#516381",
"euiColorDisabled": "#E3E8F2",
"euiColorPrimaryText": "#1750BA",
"euiColorSuccessText": "#09724D",
Expand Down
4 changes: 2 additions & 2 deletions packages/eui-theme-borealis/src/variables/colors/_colors_light.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ $euiColorBackgroundFilledText: $euiColorShade90 !default;
// Texts (legacy)
$euiTextColor: $euiColorShade135 !default;
$euiTitleColor: $euiColorShade140 !default;
$euiTextSubduedColor: $euiColorShade90 !default;
$euiTextSubduedColor: $euiColorShade95 !default;
$euiColorDisabled: $euiColorBackgroundBaseDisabled !default;
$euiColorDisabledText: $euiColorShade70 !default;
$euiLinkColor: $euiColorPrimary100 !default;

// Texts
$euiColorTextParagraph: $euiColorShade135 !default;
$euiColorTextHeading: $euiColorShade140 !default;
$euiColorTextSubdued: $euiColorShade90 !default;
$euiColorTextSubdued: $euiColorShade95 !default;
$euiColorTextDisabled: $euiColorShade70 !default;
$euiColorTextInverse: $euiColorPlainLight !default;

Expand Down
4 changes: 2 additions & 2 deletions packages/eui-theme-borealis/src/variables/colors/_colors_light.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ export const text_colors: _EuiThemeTextColors = {
/* Legacy colors */
text: SEMANTIC_COLORS.shade135,
title: SEMANTIC_COLORS.shade140,
subduedText: SEMANTIC_COLORS.shade90,
subduedText: SEMANTIC_COLORS.shade95,
link: SEMANTIC_COLORS.primary100,

/* New colors */
textParagraph: SEMANTIC_COLORS.shade135,
textHeading: SEMANTIC_COLORS.shade140,
textSubdued: SEMANTIC_COLORS.shade90,
textSubdued: SEMANTIC_COLORS.shade95,
textDisabled: SEMANTIC_COLORS.shade70,
textInverse: SEMANTIC_COLORS.plainLight,
};
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src-docs/src/views/theme/_json/eui_theme_borealis_light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@
"euiColorHighlight": "#E5F3FF",
"euiTextColor": "#172336",
"euiTitleColor": "#111C2C",
"euiTextSubduedColor": "#5A6D8C",
"euiTextSubduedColor": "#516381",
"euiColorDisabled": "#E3E8F2",
"euiColorPrimaryText": "#1750BA",
"euiColorSuccessText": "#09724D",
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/breadcrumbs/_breadcrumb_content.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const euiBreadcrumbContentStyles = (euiThemeContext: UseEuiTheme) => {
/* TODO: Remove this ':not()' selector and simply have this be
baseline CSS once the 'color' prop is removed */
&:not(.euiLink) {
color: ${euiTheme.colors.subduedText};
color: ${euiTheme.colors.textSubdued};
}
`,

Expand Down