[High Contrast Mode] Markdown, highlighting, misc text fixes #8219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ address TODO
- get noisy diffs out of the way
- simplify default to just use border color token - tweak subdued color, leave rest alone
- particularly noticeable with high contrast borders
- render bottom border for column variant in high contrast mode - do not render bottom border for non-clickable elements - it's confusing for windows high contrast - add more VRT
+ update VRT screenshots - looks like just aliasing changes
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
mgadewoll
reviewed
Dec 11, 2024
Contributor
Author
|
@mgadewoll With your comments answered, is this PR approved/good to merge, or are you still QAing/reviewing? |
mgadewoll
approved these changes
Dec 11, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ Thanks for the additional explanations! Everything worked as expected, code LGTM 👍
cee-chen
added a commit
that referenced
this pull request
Dec 12, 2024
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 14, 2025
12 tasks
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
EuiMarkdown had some misc cleanup while here, and I opinionatedly changed the borders of its default tables/blockquotes/hr's etc to use our existing border color token. All other changes are either relatively straightforward or documented in git commits.
QA
Customize propstoggle, especially switching colors<kbd>fix (Windows high contrast themes should not be broken/look the same as non-high-contrast)General checklist
and screenreader modes- [ ] Checked in mobile- [ ] Added or updated jest and cypress tests