-
Notifications
You must be signed in to change notification settings - Fork 861
[High Contrast Mode] Allow forced high contrast themes to also force color mode #8200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cee-chen
merged 6 commits into
elastic:high-contrast-mode
from
cee-chen:high-contrast-forced
Dec 4, 2024
Merged
[High Contrast Mode] Allow forced high contrast themes to also force color mode #8200
cee-chen
merged 6 commits into
elastic:high-contrast-mode
from
cee-chen:high-contrast-forced
Dec 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ move system state definition below long comment blocks
5f2c6ea to
faa1510
Compare
mgadewoll
approved these changes
Dec 4, 2024
Contributor
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐈⬛ The updates works as expected and code LGTM 👍
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
cee-chen
added a commit
that referenced
this pull request
Dec 6, 2024
cee-chen
added a commit
that referenced
this pull request
Dec 12, 2024
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 14, 2025
12 tasks
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
The impetus for this PR stems from this earlier conversation: #8193 (comment)
Essentially, our use of
forced-color-adjust: nonecan cause visibility issues withfullShade/emptyShade, if we don't respect high contrast themes that force light/dark mode.At this point, we need to treat forced colors/high contrast themes as superceding any application setting (since they do in reality) - hence this architectural change.
QA
General checklist
- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Props have proper autodocs (using@defaultif default values are missing) and playground toggles- [ ] Checked Code Sandbox works for any docs examplesand cypress tests- [ ] Updated visual regression tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)