Skip to content

[Visual Refresh] Fix theme package builds #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgadewoll merged 1 commit into from
Nov 7, 2024
Merged

[Visual Refresh] Fix theme package builds #8120

mgadewoll merged 1 commit into from
Nov 7, 2024

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 6, 2024 •
edited
Loading

Summary

This PR updates the builds for the new theme packages that ensure Kibana CI runs as expected:

  • ensure core-js polyfills are handled as expected
  • align eui-theme-borealis package build with eui-theme-common build to ensure both esm and cjs packages are available

QA

  • CI builds
  • Kibana CI doesn't run into errors of missing modules or import statements (before, after)

@mgadewoll mgadewoll requested a review from tkajtoch November 6, 2024 07:28
@kibanamachine
Copy link

kibanamachine commented Nov 6, 2024

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 6, 2024

💚 Build Succeeded

tkajtoch
tkajtoch approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@tkajtoch tkajtoch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I'm approving it now but let me know if there are any additional changes

@mgadewoll
Copy link
Contributor Author

mgadewoll commented Nov 7, 2024 •
edited
Loading

The changes look good. I'm approving it now but let me know if there are any additional changes

Sure! I realized I forgot to remove "Draft" state 😅
I'll merge this PR first and will need to rebase this one after as they touch similar code around the build script.

@mgadewoll mgadewoll marked this pull request as ready for review November 7, 2024 11:54
@mgadewoll mgadewoll requested a review from a team as a code owner November 7, 2024 11:54
@mgadewoll mgadewoll merged commit 7a5913d into elastic:eui-theme/borealis Nov 7, 2024
@mgadewoll mgadewoll mentioned this pull request Nov 7, 2024
Merged
3 tasks
mgadewoll added a commit that referenced this pull request Nov 8, 2024
@mgadewoll
[Visual Refresh] Fix theme package builds (#8120)
40c1fb0
mgadewoll added a commit that referenced this pull request Nov 13, 2024
@mgadewoll
[Visual Refresh] Fix theme package builds (#8120)
6bb54fc
tkajtoch pushed a commit that referenced this pull request Nov 20, 2024
@mgadewoll @tkajtoch
[Visual Refresh] Fix theme package builds (#8120)
25372fc
tkajtoch pushed a commit that referenced this pull request Nov 27, 2024
@mgadewoll @tkajtoch
[Visual Refresh] Fix theme package builds (#8120)
643344b
tkajtoch pushed a commit that referenced this pull request Dec 16, 2024
@mgadewoll @tkajtoch
[Visual Refresh] Fix theme package builds (#8120)
957398e
tkajtoch pushed a commit that referenced this pull request Dec 17, 2024
@mgadewoll @tkajtoch
[Visual Refresh] Fix theme package builds (#8120)
c8aaaad
mgadewoll added a commit that referenced this pull request Jan 7, 2025
@mgadewoll
[Visual Refresh] Fix theme package builds (#8120)
b8b6069
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
@mgadewoll
[Visual Refresh] Fix theme package builds (elastic#8120)
f3171b8
@mgadewoll mgadewoll mentioned this pull request Mar 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkajtoch tkajtoch tkajtoch approved these changes

Assignees

No one assigned

Labels

visual refresh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgadewoll @kibanamachine @elasticmachine @tkajtoch