[Visual Refresh] Design changes #8111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
the
skip-changelog
refactor: add button group focus token
- updates form borders
opinionated: refactors how popover arrows are built; uses element over borders to ensure we can add borders and reduces needed css
mgadewoll
force-pushed
the
eui-theme/design-changes
branch
from
3a7fb28 to
594ab06
Compare
3 tasks
mgadewoll
force-pushed
the
eui-theme/design-changes
branch
from
0c33c1e to
b4fd0b9
Compare
-adds flaoting boarder on dark mode only to prevent layout changes for child components due to transparent border on light mode
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Nov 4, 2024
Member
tkajtoch
left a comment
tkajtoch
left a comment
There was a problem hiding this comment.
The changes look great! I like the simplicity of adding flags as another theme object. It's perfect for our current use case
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 13, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 20, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 16, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 17, 2024
mgadewoll
added a commit
that referenced
this pull request
Jan 7, 2025
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
This PR contains latest design updates to the new theme.
Changes
🎨 Changes added reflect expected design changes mentioned here.
lightestShadetoken value for light mode toshade15QA