-
Notifications
You must be signed in to change notification settings - Fork 861
[Visual Refresh] Setup semantic color tokens #8097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mgadewoll
merged 36 commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-126-semantic-color-tokens
Oct 31, 2024
Merged
[Visual Refresh] Setup semantic color tokens #8097
mgadewoll
merged 36 commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-126-semantic-color-tokens
Oct 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
311817a to
641159f
Compare
move temp transparent backgrounds to temporary component tokens
…transparent colors to use new transparent colors
- move form specific tokens to themes
1beabf2 to
c980206
Compare
tkajtoch
reviewed
Oct 31, 2024
tkajtoch
reviewed
Oct 31, 2024
packages/eui-theme-borealis/src/variables/colors/_primitive_colors.ts
Outdated
Show resolved
Hide resolved
tkajtoch
approved these changes
Oct 31, 2024
Member
tkajtoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great. Considering it's targetting a feature branch I don't have any objections
ensure only tests in src are run
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
Member
|
I'm happy with the latest changes. LGTM! |
tkajtoch
pushed a commit
that referenced
this pull request
Oct 31, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 13, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 20, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 16, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Dec 17, 2024
mgadewoll
added a commit
that referenced
this pull request
Jan 7, 2025
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
skip-changelog
Use on PRs to skip changelog requirement (Don't delete - used for automation)
visual refresh
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes https://github.com/elastic/eui-private/issues/125
closes https://github.com/elastic/eui-private/issues/126
This PR implements the base setup for colors tokens. The main idea is to remove our dependency on color calculations and use direct token values instead. To ensure this works in both themes we lift the old color calculations up to the theme definitions level.
Additionally all existing tokens are kept to ensure backwards compatibility and the values were updated for the new theme to match expected output.
The token naming is mapped to variables in Figma.
The implemented theme structure:
The
colorskey now holds a lot more color tokens. These new tokens are (grouped):primary10andshade10)The
componentskey contains:buttonskey which holds button specific tokensformskey which holds form specific tokensChanges
componentskey on the EuiTheme and adds component specific color tokensshadeandtintandtransparentize(where possible and/or necessary at this time) by adding tokens insteadeuiBackgroundColor,euiBorderColor,euiButtonColor,euiButtonFilledColorandeuiButtonEmptyColorto return tokensaccentSecondary(currently enabled as background color)accentSecondaryto relevant componentsImportant
This update does not include an update to the static JSON token files.
QA