[EuiCollapsibleNavBeta] Fix z-index level to match production EuiCollapsibleNav#8075
[EuiCollapsibleNavBeta] Fix z-index level to match production EuiCollapsibleNav#8075cee-chen wants to merge 2 commits intoelastic:mainfrom
Conversation
|
@sebelga Just to check, do you see any issues with increasing the z-index of the serverless nav to be above popovers especially when in push / non-mobile mode? |
💚 Build Succeeded
|
|
hey @cee-chen after thinking a bit I realized that even though this is correct course of action for eui library in isolation, for kibana this will block adoption of eui version that releases this change, because there are a lot of elements currently that are above navigation and after this change will be below, for example the timeline, which currently sits at 1003 z index etc... We need to first fix z-index usage in kibana and correctly position relationships between stacked z-indices across the ui using https://eui.elastic.co/#/theming/more-tokens%23levels as a reference. cc: @elastic/security-threat-hunting-explore @elastic/security-threat-hunting-investigations |
|
Gotcha, no worries, I can scrap this PR if it will interfere with Kibana. Thank you for investigating this so thoroughly @kapral18! |
I wonder if that would impact this popover (tour) that we added elastic/kibana#194926. Althoug it is declared inside the header. |
|
Popovers inherit the z-index of the element they are anchored to and sit 2000 levels above that, so if the tour is inside the header, it should be fine. But either way no worries, I'll go ahead and close this PR out for the blockers that Karen mentioned above. |
Summary
This ensures that the nav sits above any EuiTourStep or other popover elements (otherwise, popovers by default will sit above flyouts). Thank you to @kapral18 for pointing this out to us.
EuiCollapsibleNav styles:
eui/packages/eui/src/components/collapsible_nav/collapsible_nav.styles.ts
Line 17 in 5c40315
VRT screenshots appear to be minute pixel-level changes, I'm just adding them in here to get them updated
QA
6000General checklist
- [ ] Checked in both light and dark modes- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Added or updated jest and cypress tests