Fix Loki failures locally with non-cached Docker images#8074
Merged
cee-chen merged 2 commits intoelastic:mainfrom Oct 15, 2024
Merged
Fix Loki failures locally with non-cached Docker images#8074cee-chen merged 2 commits intoelastic:mainfrom
cee-chen merged 2 commits intoelastic:mainfrom
Conversation
- latest will fail with `read ECONNRESET` otherwise
- requires an updated selector now that we render popovers into story bodies
cee-chen
added
testing
Collaborator
💚 Build Succeeded
|
Contributor
|
@cee-chen I think I would not update images here, mainly for the reason you mentioned: It will be hard to know what changes are expected. But also secondly: I have the feeling that lately there are always some small changes (they always look related to font-rendering) which makes me worry that updating them all here won't actually mean they won't trigger updates again 🫠 |
mgadewoll
approved these changes
Oct 15, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
Sad to see Loki degrade like this 🙈 We really will need to check for other options but thanks for pinning the version to prevent the current issue for now!
Contributor
Author
|
That all makes sense! Thanks Lene! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@weronikaolejniczak and I have been fighting this locally. It appears that Loki no longer works with latest Chrome images and must be pinned to be able to run locally.
While here, I fixed a random test that was failing
yarn loki updatedue to #8003.@mgadewoll, not sure if we should take advantage of this PR to update all images to latest at this point, or if that would be too much / too easy to let random breakages slip through the cracks.
QA
N/A, dev only