Re-add more of a README to packages/eui/
#8058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
documentation
- without completely duplicating the FAQ, wiki links, etc
Collaborator
💚 Build Succeeded
|
tkajtoch
approved these changes
Oct 7, 2024
Member
tkajtoch
left a comment
tkajtoch
left a comment
There was a problem hiding this comment.
happened to me before too! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I pruned the duplicate READMEs in #8029 (between
/and/packages/eui/without realizing that/packages/eui/is what determines what renders in https://www.npmjs.com/package/@elastic/eui, so we now have a very sad looking NPM package 🤦I've brought back some of the higher level content with links without going so far as to duplicate the FAQ and more detailed docs/copy from the root README.
QA
General checklist
N/A, internal only