[Storybook] Fix infinite rerendering bug introduced in #8003#8024
Merged
cee-chen merged 2 commits intoelastic:mainfrom Sep 16, 2024
Merged
[Storybook] Fix infinite rerendering bug introduced in #8003#8024cee-chen merged 2 commits intoelastic:mainfrom
cee-chen merged 2 commits intoelastic:mainfrom
Conversation
…Storybook state - for whatever reason, storybook's useState was causing infinite looping rerenders :| we should just create a new React component that supports state/refs and call it a day
- cleaner, contain concerns in a single file
cee-chen
added
the
skip-changelog
Collaborator
💚 Build Succeeded
|
mgadewoll
approved these changes
Sep 16, 2024
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ Computer melting was successfully averted.
I tested it locally and can't reproduce the infinite looping anymore 👍
And nice additional re-organization of the code 🧹
| * Primary EuiProvider decorator to wrap around all stories | ||
| * @see https://storybook.js.org/docs/writing-stories/decorators | ||
| */ | ||
| export const EuiProviderDecorator: FunctionComponent< |
Contributor
There was a problem hiding this comment.
Added benefits:
- non-melted computer ✨
- more readable code organization 🧠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(Link to #8003)
It turns out Storybook's version of
useStatewhen set on a<div ref>results in infinite rerenders 💀 🫠 Moving the added portal/ref logic to an actual React component fixes the issue and incidentally also allows us to clean up our code a bit.Real life footage of my laptop heating up to 100 degrees when I left Storybook open for hours not realizing that was happening:
QA
General checklist
N/A, internal dev only