[EuiCollapsibleNavBeta] Allow consumer to control the collapsed state #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename a few things - spy on `onCollapseToggle` callback instead of internal state setter
- remove `isCollapsedControlled` branching logic from callbacks and use a `useEffect` instead to update internal state based on prop
cee-chen
approved these changes
Aug 27, 2024
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've updated the
EuiCollapsibleNavBetacomponent to allow consumers to control the collapsed state of the navigation with aisCollapsedprop.If the prop is not set, the collapsed state is controlled by the component (same as before this PR). If it is set, it is the parent that controls the state.
This work required to be able to handle elastic/kibana#190354