Export EuiFormControlLayoutIcons#7976
Merged
cee-chen merged 1 commit intoelastic:mainfrom Aug 23, 2024
Merged
Conversation
cee-chen
added
the
skip-changelog
- Kibana's unified search query string input component needs it :T
cee-chen
force-pushed
the
export-form-control-layout-icons
branch
from
af00efb to
ab44e07
Compare
Collaborator
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required by elastic/kibana#190752
Kibana's unified search query string input was using a direct className to get form control icon styling:
https://github.com/elastic/kibana/blob/74d88580a5e3d24c6421942f2c96a8dfd56d39d1/src/plugins/unified_search/public/query_string_input/query_string_input.tsx#L854-L856
Which will no longer work with its Emotion conversion. I had assumed I could reach into
@elastic/eui/lib/componentsdirectly to importEuiFormControlLayoutIcons, but Kibana's optimizer is throwing build errors when I attempt to do so (related to importing EuiIcon 💀)QA
N/A
General checklist
N/A, backport only and a Kibana-only concern