Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jul 29, 2024

Summary

The previous example code was polluting the default link validator plugin, leading to https://eui.elastic.co/v94.2.0/#/editors-syntax/markdown-format#link-validation-for-security incorrectly not parsing http links. This PR fixes the example to use the new exclude configs we added in #7676, and is overall a significantly cleaner approach in any case.

QA

General checklist

N/A, docs only change

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Jul 29, 2024
@cee-chen cee-chen changed the title [Docs] Fix EuiMarkdownEditor plugin polluting other examples [Docs] Fix EuiMarkdownEditor plugin example polluting other examples Jul 29, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@JasonStoltz JasonStoltz marked this pull request as ready for review July 29, 2024 21:32
@JasonStoltz JasonStoltz requested a review from a team as a code owner July 29, 2024 21:32
@cee-chen cee-chen merged commit 27ab9fd into elastic:main Jul 29, 2024
@cee-chen cee-chen deleted the docs/markdown-link-validation-example branch July 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants